-
Notifications
You must be signed in to change notification settings - Fork 91
Fix codacy warnings #680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix codacy warnings #680
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,7 +5,9 @@ | |
| from .block.message_passing import EquivariantGraphNeuralOperatorBlock | ||
|
|
||
|
|
||
| class EquivariantGraphNeuralOperator(torch.nn.Module): | ||
| # Disable pylint warnings for too few public methods (since this is a simple | ||
| # model class in a standard PyTorch style) | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I would remove these comments — the pylint disable is sufficient both to suppress the error and to trace it back if needed. |
||
| class EquivariantGraphNeuralOperator(torch.nn.Module): # pylint: disable=R0903 | ||
| """ | ||
| Equivariant Graph Neural Operator (EGNO) for modeling 3D dynamics. | ||
|
|
||
|
|
@@ -32,7 +34,9 @@ class EquivariantGraphNeuralOperator(torch.nn.Module): | |
| <https://arxiv.org/abs/2401.11037>`_ | ||
| """ | ||
|
|
||
| def __init__( | ||
| # Disable pylint warnings for too many arguments in init (since this is a | ||
| # model class with many configurable parameters) | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I would remove these comments — the pylint disable is sufficient both to suppress the error and to trace it back if needed. |
||
| def __init__( # pylint: disable=R0913, R0917, R0914 | ||
| self, | ||
| n_egno_layers, | ||
| node_feature_dim, | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would remove these comments — the pylint disable is sufficient both to suppress the error and to trace it back if needed.