Fix codacy warnings #680
Closed
Fix codacy warnings #680
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dario-coscia
requested changes
Oct 21, 2025
Collaborator
dario-coscia
left a comment
dario-coscia
left a comment
There was a problem hiding this comment.
I am against the use of pylint disable. We can discuss disabling some pylits if they are unnecessary, but I would avoid adding specific calls
Contributor
|
Code Coverage SummaryResults for commit: 42e9933 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
GiovanniCanali
requested changes
Oct 23, 2025
Collaborator
GiovanniCanali
left a comment
GiovanniCanali
left a comment
There was a problem hiding this comment.
Hi @FilippoOlivo,
While we’re still discussing whether to disable pylint errors or not, I kindly ask you to remove the comments explaining the errors. They’re not code-related, and it’s easy to trace the issue directly from the error code itself.
| # Convolution in Fourier space | ||
| fourier = torch.fft.rfftn(x, dim=[0])[:modes] | ||
| # torch.fft.rfftn and irfftn are callable functions, but pylint | ||
| # incorrectly flags them as E1102 (not callable). |
Collaborator
There was a problem hiding this comment.
I would remove these comments — the pylint disable is sufficient both to suppress the error and to trace it back if needed.
|
|
||
| class EquivariantGraphNeuralOperator(torch.nn.Module): | ||
| # Disable pylint warnings for too few public methods (since this is a simple | ||
| # model class in a standard PyTorch style) |
Collaborator
There was a problem hiding this comment.
I would remove these comments — the pylint disable is sufficient both to suppress the error and to trace it back if needed.
|
|
||
| def __init__( | ||
| # Disable pylint warnings for too many arguments in init (since this is a | ||
| # model class with many configurable parameters) |
Collaborator
There was a problem hiding this comment.
I would remove these comments — the pylint disable is sufficient both to suppress the error and to trace it back if needed.
Collaborator
|
@FilippoOlivo I will close this issue. Please see #674. Can you open an issue where you explain the current Codacy situation and how we could improve it in a structured and maintainable way? Thank you for your effort! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes codacy warnings introduced in #602
Checklist