fix compilation errors and minor deprecations for Android 13 #6196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #6196 +/- ##
============================================
- Coverage 68.86% 68.86% -0.01%
+ Complexity 4340 4338 -2
============================================
Files 650 650
Lines 26106 26104 -2
Branches 3061 3061
============================================
- Hits 17978 17976 -2
Misses 6965 6965
Partials 1163 1163
|
dzinad
force-pushed
the
dd-1894-minor-adaptions
branch
from
7968992 to
4f03e59
Compare
dzinad
force-pushed
the
dd-1894-minor-adaptions
branch
from
4f03e59 to
8e55aa7
Compare
...-core/src/main/java/com/mapbox/navigation/core/trip/service/NavigationNotificationService.kt
Outdated
Show resolved
Hide resolved
dzinad
force-pushed
the
dd-1894-minor-adaptions
branch
3 times, most recently
from
51725eb to
a29d544
Compare
LukasPaczos
approved these changes
Aug 31, 2022
LukasPaczos
reviewed
Aug 31, 2022
CHANGELOG.md
Outdated
| - Fixed `MapboxNavigationApp#detach` will not fully detach. This causes `MapboxNavigation` to continue to be accessible, and causes `MapboxNavigationObserver.onDetached` to be called multiple times. | ||
| - Added Android 13 support. [#6196](https://github.com/mapbox/mapbox-navigation-android/pull/6196) | ||
| - Declared [POST_NOTIFICATIONS](https://developer.android.com/reference/android/Manifest.permission#POST_NOTIFICATIONS) permission in SDK's AndroidManifest.xml. It is highly recommended for apps to request the permission in runtime, Without it the SDK will not be able to show the notification with trip progress in the notification drawer for apps that target Android 13 or higher. [#6196](https://github.com/mapbox/mapbox-navigation-android/pull/6196) | ||
| - Bumped targetSdkVersion to 33. [#6196](https://github.com/mapbox/mapbox-navigation-android/pull/6196) |
There was a problem hiding this comment.
Is this actually relevant to app developers? The app manifest has a higher priority and its targetSdkVersion will be chosen in the manifest merger either way.
dzinad
force-pushed
the
dd-1894-minor-adaptions
branch
from
a29d544 to
29ef2fb
Compare
dzinad
force-pushed
the
dd-1894-minor-adaptions
branch
from
29ef2fb to
d00b2a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.