Skip to content

Commit 51725eb

Browse files
committed
target Android 13
1 parent 7ec7527 commit 51725eb

File tree

10 files changed

+24
-17
lines changed

10 files changed

+24
-17
lines changed

CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,9 @@ Mapbox welcomes participation and contributions from everyone.
99
- Fixed routes’ incorrect duration: now it relays on annotations if provided, otherwise on steps’s duration. [#6237](https://github.com/mapbox/mapbox-navigation-android/pull/6237)
1010
- Added `guideMapUri` to the `RestStop`. [#6237](https://github.com/mapbox/mapbox-navigation-android/pull/6237)
1111
- [TileStore Android Service] Fixed a crash when the service process is killed by the Android system. [#6237](https://github.com/mapbox/mapbox-navigation-android/pull/6237)
12+
- Added Android 13 support. [#6196](https://github.com/mapbox/mapbox-navigation-android/pull/6196)
13+
- Declared [POST_NOTIFICATIONS](https://developer.android.com/reference/android/Manifest.permission#POST_NOTIFICATIONS) permission in SDK's AndroidManifest.xml. It is highly recommended for apps to request the permission in runtime, Without it the SDK will not be able to show the notification with trip progress in the notification drawer for apps that target Android 13 or higher. [#6196](https://github.com/mapbox/mapbox-navigation-android/pull/6196)
14+
- Bumped targetSdkVersion to 33. [#6196](https://github.com/mapbox/mapbox-navigation-android/pull/6196)
1215

1316
## Mapbox Navigation SDK 2.8.0-beta.1 - 25 August, 2022
1417
### Changelog

gradle/dependencies.gradle

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@ ext {
33

44
androidVersions = [
55
minSdkVersion : 21,
6-
targetSdkVersion : 31,
7-
compileSdkVersion : 31,
6+
targetSdkVersion : 33,
7+
compileSdkVersion : 33,
88
carMinSdkVersion : 23
99
]
1010

libnavigation-core/src/main/AndroidManifest.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
<uses-permission android:name="android.permission.ACCESS_COARSE_LOCATION" />
66
<uses-permission android:name="android.permission.ACCESS_FINE_LOCATION" />
77
<uses-permission android:name="android.permission.FOREGROUND_SERVICE" />
8+
<uses-permission android:name="android.permission.POST_NOTIFICATIONS" />
89

910
<application>
1011

libnavigation-core/src/main/java/com/mapbox/navigation/core/trip/service/NavigationNotificationService.kt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ import android.app.Service
55
import android.content.Context
66
import android.content.Intent
77
import android.os.IBinder
8+
import androidx.core.app.ServiceCompat
89
import com.mapbox.navigation.core.telemetry.MapboxNavigationTelemetry
910

1011
/**
@@ -43,7 +44,7 @@ internal class NavigationNotificationService : Service() {
4344
*/
4445
override fun onDestroy() {
4546
super.onDestroy()
46-
stopForeground(true)
47+
ServiceCompat.stopForeground(this, ServiceCompat.STOP_FOREGROUND_REMOVE)
4748
MapboxTripService.unregisterOneTimeNotificationDataObserver(notificationDataObserver)
4849
}
4950
}

libnavigation-core/src/test/java/com/mapbox/navigation/core/navigator/LocationExTest.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,7 @@ class LocationExTest {
141141
assertEquals(ZERO_VALUE, bearingAccuracyDegrees, .0f)
142142
assertEquals(ZERO_VALUE, speedAccuracyMetersPerSecond, .0f)
143143
assertEquals(ZERO_VALUE, verticalAccuracyMeters, .0f)
144-
assertEquals(EMPTY_EXTRAS.toString(), extras.toMap().toString())
144+
assertEquals(EMPTY_EXTRAS.toString(), extras!!.toMap().toString())
145145
assertEquals(IS_MOCK, isFromMockProvider)
146146
}
147147
}

libnavigation-metrics/src/test/java/com/mapbox/navigation/metrics/MapboxMetricsReporterTest.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ class MapboxMetricsReporterTest {
110110
override val metricName: String
111111
) : Event(), MetricEvent {
112112

113-
override fun writeToParcel(dest: Parcel?, flags: Int) {}
113+
override fun writeToParcel(dest: Parcel, flags: Int) {}
114114

115115
override fun describeContents(): Int = 0
116116

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
sdk=31

libnavui-maps/src/main/java/com/mapbox/navigation/ui/maps/camera/NavigationCamera.kt

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -436,12 +436,12 @@ class NavigationCamera(
436436

437437
private var isCanceled = false
438438

439-
override fun onAnimationStart(animation: Animator?) {
439+
override fun onAnimationStart(animation: Animator) {
440440
this@NavigationCamera.frameTransitionOptions = DEFAULT_FRAME_TRANSITION_OPT
441441
state = progressState
442442
}
443443

444-
override fun onAnimationEnd(animation: Animator?) {
444+
override fun onAnimationEnd(animation: Animator) {
445445
if (!isCanceled) {
446446
this@NavigationCamera.frameTransitionOptions = frameTransitionOptions
447447
state = finalState
@@ -453,29 +453,29 @@ class NavigationCamera(
453453
updateFrame(viewportDataSource.getViewportData(), instant = false)
454454
}
455455

456-
override fun onAnimationCancel(animation: Animator?) {
456+
override fun onAnimationCancel(animation: Animator) {
457457
isCanceled = true
458458
}
459459

460-
override fun onAnimationRepeat(animation: Animator?) {
460+
override fun onAnimationRepeat(animation: Animator) {
461461
}
462462
}
463463

464464
private fun createFrameListener() = object : Animator.AnimatorListener {
465465

466-
override fun onAnimationStart(animation: Animator?) {
466+
override fun onAnimationStart(animation: Animator) {
467467
// no impl
468468
}
469469

470-
override fun onAnimationEnd(animation: Animator?) {
470+
override fun onAnimationEnd(animation: Animator) {
471471
finishAnimation(animation as AnimatorSet)
472472
}
473473

474-
override fun onAnimationCancel(animation: Animator?) {
474+
override fun onAnimationCancel(animation: Animator) {
475475
// no impl
476476
}
477477

478-
override fun onAnimationRepeat(animation: Animator?) {
478+
override fun onAnimationRepeat(animation: Animator) {
479479
// no impl
480480
}
481481
}
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
sdk=31

libnavui-util/src/main/java/com/mapbox/navigation/ui/utils/internal/extensions/ViewEx.kt

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -40,19 +40,19 @@ fun ValueAnimator.play(
4040
set.play(this)
4141
set.interpolator = AccelerateDecelerateInterpolator()
4242
set.addListener(object : Animator.AnimatorListener {
43-
override fun onAnimationStart(animation: Animator?) {
43+
override fun onAnimationStart(animation: Animator) {
4444
doOnStart?.invoke()
4545
}
4646

47-
override fun onAnimationEnd(animation: Animator?) {
47+
override fun onAnimationEnd(animation: Animator) {
4848
doOnEnd?.invoke()
4949
}
5050

51-
override fun onAnimationCancel(animation: Animator?) {
51+
override fun onAnimationCancel(animation: Animator) {
5252
// No implementation
5353
}
5454

55-
override fun onAnimationRepeat(animation: Animator?) {
55+
override fun onAnimationRepeat(animation: Animator) {
5656
// No implementation
5757
}
5858
})

0 commit comments

Comments
 (0)