Skip to content

Conversation

@Guardiola31337
Copy link
Contributor

Description

Goal

Getting the latest version from mapboxMapSdk including the new features and bug fixes

Implementation

Bumping the mapboxMapSdk version to 7.3.2 in dependencies.gradle

Testing

Tested that all the Activities in the test app and didn't 👀 any issues

  • I have tested locally (including SNAPSHOT upstream dependencies if needed)
  • I have tested via a test drive, or a simulation/mock location app
  • New and existing unit tests pass locally with my changes

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code

@Guardiola31337 Guardiola31337 added this to the v0.36.0 milestone Apr 17, 2019
@Guardiola31337 Guardiola31337 self-assigned this Apr 17, 2019
Copy link
Contributor

@danesfeder danesfeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Guardiola31337 🚢

@danesfeder
Copy link
Contributor

danesfeder commented Apr 17, 2019

Looks good 👍

ezgif com-video-to-gif

@codecov-io
Copy link

Codecov Report

Merging #1894 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1894   +/-   ##
=========================================
  Coverage     34.95%   34.95%           
  Complexity     1049     1049           
=========================================
  Files           260      260           
  Lines          8817     8817           
  Branches        667      667           
=========================================
  Hits           3082     3082           
  Misses         5466     5466           
  Partials        269      269

@Guardiola31337 Guardiola31337 merged commit 63e945c into master Apr 17, 2019
@Guardiola31337 Guardiola31337 deleted the pg-bump-maps-7.3.2 branch April 17, 2019 15:36
@Guardiola31337 Guardiola31337 mentioned this pull request Apr 17, 2019
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Defect to be fixed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Way name outdated after resuming navigation

4 participants