Skip to content

Added default Expires header and enabled apache served files compression by default. #4390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

miguelbalparda
Copy link
Contributor

@miguelbalparda
Copy link
Contributor Author

@magento-cicd2 I just signed the agreement with my github account but it still appears as unsigned.

@miguelbalparda
Copy link
Contributor Author

@tanya-soroka @okorshenko can you take a look at this PR? Context here #1615 (comment) BTW I can't sign the CLA.

@pboisvert
Copy link

@miguelbalparda by your last comment do you mean that the UX will not allow you to sign the CLA or that you cannot sign the CLA for another reason?

@miguelbalparda
Copy link
Contributor Author

Sorry my bad @pboisvert. I tried to sign the CLA several times and I'm always being redirected back here after accepting but it still says "Contributor License Agreement is not signed yet."

@pboisvert
Copy link

ok, thanks--we will check into that. Not sure what is happening with the CLA.

@miguelbalparda
Copy link
Contributor Author

Good stuff, I tried Chrome and Firefox to rule out the browser. Same result.

@piotrekkaminski
Copy link
Contributor

hey @miguelbalparda . This is now solved. There was a bug in CLA code that caused some signatures not to be reflected properly and we fixed those instances as well as implemented new version of CLA code that should work ok. Thanks for letting us know. cc @pboisvert @benmarks

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Aug 25, 2016

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


mbalparda seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

@miguelbalparda
Copy link
Contributor Author

Closing in favor of #7505

magento-engcom-team pushed a commit that referenced this pull request Jun 23, 2019
[MPI] Authorize.net - 3D Secure 2.0 Support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants