Skip to content

Uncommented mod_expires and mod_deflate from .htaccess #7505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Uncommented mod_expires and mod_deflate from .htaccess #7505

wants to merge 1 commit into from

Conversation

miguelbalparda
Copy link
Contributor

@zekefarwell
Copy link

+1. Looks like a no brainer to me.

@choukalos
Copy link

+1; Thanks @miguelbalparda - I pinged internally to raise priority of accepting this PR.

@choukalos
Copy link

choukalos commented Nov 22, 2016

Hey @miguelbalparda - I chatted with the front-end team about this PR; we can't accept this PR. Sounds like most of this PR will already be covered by planned work for all upcoming releases (aka 2.2, 2.1.3, 2.0.11).

  • Pub/Static & Pub/Media have .htaccess settings already for mod_expires and mod_headers
  • mod_deflate is a gap; but it's been added to the ticket; as always for it to work merchant needs to have appropriate mod installed & configured on their server.
  • Also you didn't make the changes to the htaccess.sample file

So per discussion with the team closing this PR; you should see the equivalent changes in our upcoming patch releases.

@choukalos choukalos closed this Nov 22, 2016
@miguelbalparda
Copy link
Contributor Author

miguelbalparda commented Nov 22, 2016

Got it, thanks for the quick reply and tell the team(s) they are doing an amazing work!

@miguelbalparda
Copy link
Contributor Author

@choukalos can we revisit this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants