Skip to content

Add back extension point for adding some html to the category page #29291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 15, 2020

Conversation

iGerchak
Copy link
Contributor

@iGerchak iGerchak commented Jul 27, 2020

Description (*)

Moved check from the catalog to the swatches module in order to add back the extension point.

Fixed Issues (if relevant)

  1. Fixes Add back extension point for adding some html to the category page #29286

Manual testing scenarios (*)

  1. See Fixed LayeredNavigation color filter show only loader for out of stock product #24728 and Add back extension point for adding some html to the category page #29286

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Jul 27, 2020

Hi @iGerchak. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@iGerchak
Copy link
Contributor Author

@magento run all tests

@ghost ghost added the Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. label Jul 27, 2020
@ihor-sviziev
Copy link
Contributor

Oh, thx for fixing it so quickly

@ihor-sviziev ihor-sviziev self-assigned this Jul 27, 2020
@ihor-sviziev ihor-sviziev added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Jul 27, 2020
@ihor-sviziev
Copy link
Contributor

@magento run all tests

Copy link
Contributor

@ihor-sviziev ihor-sviziev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iGerchak please fix static tests

@iGerchak
Copy link
Contributor Author

@magento run all tests

@ihor-sviziev
Copy link
Contributor

@magento run all tests

@ihor-sviziev
Copy link
Contributor

@magento run all tests

@ghost ghost removed the Progress: needs update label Jul 29, 2020
@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-7911 has been created to process this Pull Request

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

Manual testing scenario:

  1. Set configurable product out of stock, make sure the child is in stock;
  2. Display Out of Stock Products set to Yes;
  3. select color witch available in the configurable product;

Actual Result:

✔️ listing page not showing swatch for out of stock product same as on product detail page

2020-08-05_11-40

and everything related to the swatch functionality was also checked

@engcom-Charlie engcom-Charlie self-assigned this Aug 5, 2020
@engcom-Charlie engcom-Charlie added the QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) label Aug 5, 2020
@ghost ghost added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Aug 13, 2020
@sidolov sidolov added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. and removed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. labels Aug 13, 2020
@engcom-Alfa engcom-Alfa added QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope and removed QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) labels Aug 14, 2020
@magento-engcom-team magento-engcom-team merged commit f410b23 into magento:2.4-develop Aug 15, 2020
@m2-assistant
Copy link

m2-assistant bot commented Aug 15, 2020

Hi @iGerchak, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Frontend Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Award: bug fix Component: Catalog Component: Swatches Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add back extension point for adding some html to the category page
6 participants