-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Add back extension point for adding some html to the category page #29291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add back extension point for adding some html to the category page #29291
Conversation
Hi @iGerchak. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review. For more details, please, review the Magento Contributor Guide documentation. 🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket. 🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
@magento run all tests |
Oh, thx for fixing it so quickly |
7d889c5
to
9bd24f9
Compare
@magento run all tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@iGerchak please fix static tests
9bd24f9
to
aeccbe5
Compare
@magento run all tests |
@magento run all tests |
@magento run all tests |
Hi @ihor-sviziev, thank you for the review. |
✔️ QA Passed Manual testing scenario:
Actual Result: ✔️ listing page not showing swatch for out of stock product same as on product detail page and everything related to the swatch functionality was also checked |
Hi @iGerchak, thank you for your contribution! |
Description (*)
Moved check from the catalog to the swatches module in order to add back the extension point.
Fixed Issues (if relevant)
Manual testing scenarios (*)
Contribution checklist (*)