Skip to content

#3993; Fix same level categories (position)re-index on category move. #23820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

sergey-solo
Copy link
Contributor

Description (*)

When category is moved, the list of categories prepared for re-indexing now includes the sibling categories.

Fixed Issues (if relevant)

  1. Category Sort Order is not saved in Flat Table #3993: Category Sort Order is not saved in Flat Table

Manual testing scenarios (*)

  1. Enable flat for categories.
  2. Add some categories of the same level to any parent category.
  3. Sort them in any order.
  4. Check the corresponding flat table and see that position indices are calculated correctly.

Questions or comments

--

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Jul 22, 2019

Hi @sergey-solo. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Jul 22, 2019

CLA assistant check
All committers have signed the CLA.

@ghost ghost assigned sidolov Aug 15, 2019
@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-5639 has been created to process this Pull Request
✳️ @sidolov, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@engcom-Delta
Copy link
Contributor

✔️ QA passed

@m2-assistant
Copy link

m2-assistant bot commented Aug 26, 2019

Hi @sergey-solo, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.4 milestone Aug 26, 2019
@sergey-solo sergey-solo deleted the m2-github-issue/3993 branch August 26, 2019 18:02
@VladimirZaets VladimirZaets added the Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests label Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants