Skip to content

Conversation

@krnshah
Copy link
Contributor

@krnshah krnshah commented Jun 10, 2019

Description (*)

If we are applying the coupon code from the admin while create order and click on "Apply coupon code" it not showing error/success msg, we have to scroll up to check the msg.
#22341

Fixed Issues (if relevant)

  1. Apply coupoun and scroll top to check. applied successfully or not #22341: Apply coupoun and scroll top to check. applied successfully or not

Manual testing scenarios (*)

  1. Admin >> Sales >> Orders
  2. Create a New Order
  3. Add Products
  4. Coupon code >> Enter invalid coupon
  5. Click on Apply button

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Jun 10, 2019

Hi @krnshah. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@XxXgeoXxX XxXgeoXxX assigned XxXgeoXxX and unassigned XxXgeoXxX Jun 11, 2019
@dmytro-ch dmytro-ch self-requested a review June 12, 2019 08:15
@dmytro-ch dmytro-ch self-assigned this Jun 12, 2019
@dmytro-ch
Copy link
Contributor

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, here is your new Magento instance.
Admin access: https://pr-23195.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@makkoff makkoff self-assigned this Jun 12, 2019
@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-5266 has been created to process this Pull Request

@makkoff
Copy link

makkoff commented Jun 12, 2019

✔️ QA Passed

@magento-engcom-team magento-engcom-team merged commit d717117 into magento:2.2-develop Jun 13, 2019
@m2-assistant
Copy link

m2-assistant bot commented Jun 13, 2019

Hi @krnshah, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Jun 13, 2019
@magento-engcom-team magento-engcom-team added this to the Release: 2.2.10 milestone Jun 13, 2019
@sidolov sidolov added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: Frontend Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Component: Sales Partner: Krish TechnoLabs partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants