Skip to content

Conversation

@krnshah
Copy link
Contributor

@krnshah krnshah commented Apr 15, 2019

Description (*)

If we are applying the coupon code from the admin while create order and click on "Apply coupon code" it not showing error/success msg, we have to scroll up to check the msg.

Fixed Issues (if relevant)

  1. magento/magento2#<issue_number>: N/A

Manual testing scenarios (*)

  1. Admin >> Sales >> Orders
  2. Create a New Order
  3. Add Products
  4. Coupon code >> Enter invalid coupon
  5. Click on Apply button

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@m2-assistant
Copy link

m2-assistant bot commented Apr 15, 2019

Hi @krnshah. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@orlangur
Copy link
Contributor

@krnshah first of all, please do not ping reviewers without prior agreement. Secondly, please report an issue so that it can be verified and then add a link to description.

Copy link
Contributor

@sidolov sidolov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, create the issue for current pull request or extend description with detailed steps to reproduce, actual and expected result. These steps can help us better understand provided fix.
Thank you!

@sidolov
Copy link
Contributor

sidolov commented May 17, 2019

@krnshah , I am closing this PR now due to inactivity.
Please reopen and update if you wish to continue.
Thank you for the collaboration!

@sidolov sidolov closed this May 17, 2019
@m2-assistant
Copy link

m2-assistant bot commented May 17, 2019

Hi @krnshah, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@krnshah krnshah reopened this May 24, 2019
@ghost ghost unassigned orlangur and sidolov May 24, 2019
@krnshah
Copy link
Contributor Author

krnshah commented May 27, 2019

I have added the description. please let me know if any information needed.

@davidverholen
Copy link
Member

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @davidverholen. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @davidverholen, here is your new Magento instance.
Admin access: https://pr-22341.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@davidverholen
Copy link
Member

@sidolov the change is basically working, so I'd approve it.
There might be better solutions from an ux perspective I guess, but this should probably be solved globally and not be discussed here

@magento-engcom-team
Copy link
Contributor

Hi @davidverholen, thank you for the review.
ENGCOM-5212 has been created to process this Pull Request

@soleksii soleksii self-assigned this Jun 6, 2019
@Nazar65 Nazar65 self-assigned this Jun 6, 2019
@soleksii
Copy link

soleksii commented Jun 6, 2019

✔️ QA Passed

Before:

before

After:

after

@m2-assistant
Copy link

m2-assistant bot commented Jun 7, 2019

Hi @krnshah, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants