Skip to content

Conversation

@cedarvinda
Copy link
Member

Issue fixed #22636

Description (*)

arrow toggle not changing only showing to down It should be toggle as every where is working

Manual testing scenarios (*)

  1. Login to admin panel
  2. Go to store link and click on Tax Rules Available on sub menu
  3. Click on add new tax rule and see Additional Settings tab and click on same

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Issue fixed #22636
@m2-assistant
Copy link

m2-assistant bot commented May 4, 2019

Hi @cedarvinda. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

_collapsible-blocks.less updated
@magento-engcom-team
Copy link
Contributor

Hi @ronak2ram, thank you for the review.
ENGCOM-5049 has been created to process this Pull Request

@VasylShvorak
Copy link
Contributor

✔️ QA passed

magento-engcom-team pushed a commit to okorshenko/magento2 that referenced this pull request May 10, 2019
… showing to down It should be toggle as every where is working magento#22644
@magento-engcom-team magento-engcom-team merged commit df69419 into magento:2.3-develop May 10, 2019
@m2-assistant
Copy link

m2-assistant bot commented May 10, 2019

Hi @cedarvinda, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment