Skip to content

Fixed issue #22767: Not clear logic for loading CMS Pages with setStoreId function #22772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
magento-engcom-team merged 2 commits into from
May 29, 2019
Merged

Fixed issue #22767: Not clear logic for loading CMS Pages with setStoreId function #22772

magento-engcom-team merged 2 commits into from
May 29, 2019

Conversation

@mahesh-rajawat
Copy link
Member

@mahesh-rajawat mahesh-rajawat commented May 7, 2019

Fixed: Not clear logic for loading CMS Pages with setStoreId function.

Description (*)

In this PR, i have fixed #22767 issue.

Fixed Issues (if relevant)

  1. Not clear logic for loading CMS Pages with setStoreId function  #22767
  2. ...

Manual testing scenarios (*)

  1. Tested it by programmatically.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@m2-assistant
Copy link

m2-assistant bot commented May 7, 2019

Hi @maheshWebkul721. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@orlangur orlangur self-assigned this May 7, 2019
@mahesh-rajawat mahesh-rajawat requested a review from dmytro-ch May 14, 2019 05:00
@mahesh-rajawat mahesh-rajawat requested review from sidolov and removed request for dmytro-ch May 22, 2019 04:42
@dmytro-ch dmytro-ch self-requested a review May 22, 2019 19:34
@dmytro-ch dmytro-ch self-assigned this May 22, 2019
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented May 22, 2019

Hi @dmytro-ch, thank you for the review.
ENGCOM-5147 has been created to process this Pull Request

@soleksii soleksii self-assigned this May 23, 2019
@soleksii
Copy link

soleksii commented May 23, 2019 •
edited
Loading

Hi @maheshWebkul721 !
Could you please make changes and for Block model (Magento\Cms\Model\Block) too?!
screen
Thanks!

@mahesh-rajawat
Copy link
Member Author

mahesh-rajawat commented May 23, 2019

@stoleksiy , Fixed it for Magento\Cms\Model\Block .

@soleksii
Copy link

soleksii commented May 23, 2019

@stoleksiy , Fixed it for Magento\Cms\Model\Block .

Thanks!

@ghost ghost assigned sidolov May 23, 2019
orlangur
orlangur requested changes May 23, 2019
View reviewed changes
Copy link
Contributor

@orlangur orlangur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash changes into a single commit so that we have perfectly clean history 😉

@mahesh-rajawat
Copy link
Member Author

mahesh-rajawat commented May 23, 2019 •
edited
Loading

Please squash changes into a single commit so that we have perfectly clean history

@orlangur, All commits squashed

@mahesh-rajawat
fixed issue magento#22767, changed the magic method type
ef5a50e 
changed the magic method type for Block Model as well
@Nazar65 Nazar65 force-pushed the fixed-issue-22767 branch from 1052f29 to 876d632 Compare May 24, 2019 11:35
@soleksii
Copy link

soleksii commented May 24, 2019

✔️ QA Passed

@Nazar65 Nazar65 self-assigned this May 24, 2019
@magento-engcom-team magento-engcom-team mentioned this pull request May 29, 2019
Closed
magento-engcom-team pushed a commit to okorshenko/magento2 that referenced this pull request May 29, 2019
@p-bystritsky
ENGCOM-5147: Fixed issue magento#22767: Not clear logic for loading C…
4c9ad14 
…MS Pages with setStoreId function magento#22772
@magento-engcom-team magento-engcom-team merged commit 876d632 into magento:2.3-develop May 29, 2019
@m2-assistant
Copy link

m2-assistant bot commented May 29, 2019

Hi @maheshWebkul721, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.3 milestone May 29, 2019
@krishprakash krishprakash mentioned this pull request Jun 6, 2019
Merged
4 tasks
krishprakash pushed a commit to krishprakash/magento2 that referenced this pull request Jun 7, 2019
@Nazar65
magento#22772 static-test-fix
70aacf1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@orlangur orlangur orlangur requested changes

@sidolov sidolov sidolov approved these changes

@dmytro-ch dmytro-ch dmytro-ch approved these changes

Assignees

@orlangur orlangur

@Nazar65 Nazar65

@sidolov sidolov

@dmytro-ch dmytro-ch

@soleksii soleksii

Labels

Cleanup Component: Cms Progress: accept Release Line: 2.3

Projects

None yet

Milestone

Release: 2.3.3

Development

Successfully merging this pull request may close these issues.

Not clear logic for loading CMS Pages with setStoreId function

7 participants

@mahesh-rajawat @magento-engcom-team @soleksii @orlangur @sidolov @dmytro-ch @Nazar65