Skip to content

Conversation

@cedarvinda
Copy link
Member

@cedarvinda cedarvinda commented May 4, 2019

issue #22706 #19647 fixed

Tooltip overlapping over the label and store label hiding in left side menu (Design issue in New Cart Price Rule)

Description (*)

Tooltip overlapping over the label and store label hiding in left side menu (Design issue in New Cart Price Rule)

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

issue #22706 fixed
@m2-assistant
Copy link

m2-assistant bot commented May 4, 2019

Hi @cedarvinda. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@rogyar
Copy link
Contributor

rogyar commented May 5, 2019

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @rogyar. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @rogyar, here is your new Magento instance.
Admin access: https://pr-22714.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@ghost ghost assigned rogyar May 5, 2019
@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-5062 has been created to process this Pull Request

@Karlasa Karlasa changed the title issue #22706 fixed issue #22706 #19647 fixed May 5, 2019
@Karlasa
Copy link
Contributor

Karlasa commented May 6, 2019

also fixes duplicated issue #20293

@soleksii
Copy link

soleksii commented May 7, 2019

Hi @cedarvinda ! I can not reproduce the issues #22706 #19647

Result:

screen

Could you please recheck on fresh 2.3-develop instance?!
Thanks!

@Karlasa
Copy link
Contributor

Karlasa commented May 7, 2019

@magento-engcom-team give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @Karlasa. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @Karlasa, here is your Magento instance.
Admin access: https://i-22714-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@Karlasa
Copy link
Contributor

Karlasa commented May 7, 2019

@stoleksiy @cedarvinda Right... it got fixed already under #22423 . Lot's of duplicated issues/PRs for this :D
Will close this PR :)

Cheers,

@Karlasa Karlasa closed this May 7, 2019
@m2-assistant
Copy link

m2-assistant bot commented May 7, 2019

Hi @cedarvinda, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants