Store view specific labels cut in left navigation menu #22406 #22423

sudhanshu-bajaj · 2019-04-19T07:54:31Z

Store view specific labels cut in left navigation menu in cart price rule.

Preconditions (*)

Magento 2.3.x

Steps to reproduce (*)

#22406

Go to Admin
Marketing >> Cart Price rule
Labels >> Store View Specific Labels
Review the Main Websites and Main Website Store labels

Expected result (*)

https://www.screencast.com/t/kQG9Kmwk

Actual result (*)

https://www.screencast.com/t/ECiEKvkHS

m2-assistant · 2019-04-19T07:54:33Z

Hi @sudhanshu-bajaj. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento-engcom-team give me test instance - deploy test instance based on PR changes
@magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

Karlasa · 2019-04-19T09:08:39Z

@magento-engcom-team give me 2.3-develop instance

magento-engcom-team · 2019-04-19T09:08:42Z

Hi @Karlasa. Thank you for your request. I'm working on Magento 2.3-develop instance for you

magento-engcom-team · 2019-04-19T09:09:32Z

Hi @Karlasa, here is your Magento instance.
Admin access: https://i-22423-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

Karlasa · 2019-04-19T09:13:42Z

@magento-engcom-team give me 2.2-develop instance

magento-engcom-team · 2019-04-19T09:13:47Z

Hi @Karlasa. Thank you for your request. I'm working on Magento 2.2-develop instance for you

magento-engcom-team · 2019-04-19T09:14:34Z

Hi @Karlasa, here is your Magento instance.
Admin access: https://i-22423-2-2-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

ghost · 2019-04-19T09:36:09Z

@sudhanshu-bajaj unfortunately, only members of the maintainers team are allowed to assign developers to the pull request

Karlasa · 2019-04-19T14:15:34Z

@magento-engcom-team give me test instance

magento-engcom-team · 2019-04-19T14:15:37Z

Hi @Karlasa. Thank you for your request. I'm working on Magento instance for you

magento-engcom-team · 2019-04-19T14:16:26Z

Hi @Karlasa, here is your new Magento instance.
Admin access: https://pr-22423.instances.magento-community.engineering/admin
Login: admin Password: 123123q

magento-engcom-team · 2019-04-19T14:51:32Z

Hi @Karlasa, thank you for the review.
ENGCOM-4788 has been created to process this Pull Request

ghost · 2019-04-22T09:00:51Z

@AlexWorking unfortunately, only members of the maintainers team are allowed to assign developers to the pull request

VasylShvorak · 2019-04-22T14:59:10Z

✔️ QA passed

VladimirZaets · 2019-04-23T19:37:09Z

app/design/adminhtml/Magento/backend/web/css/styles-old.less

        font-weight: 600;
        line-height: 3.2rem;
-        padding: 0 30px 0 0;
+        padding: 0 30px 0 30px;


Hi @sudhanshu-bajaj. Thanks for collaboration. This changes will affect all labels in each fieldset. Are you check how it will look in other usages of this styles?

@VladimirZaets Thanks for your feedback. I went through all sections by searching this class but it is not affecting any other layout. Please let me know if you found any affected area because of it.

Hey @VladimirZaets , Is there anything we need action ?

magento-engcom-team · 2019-04-30T21:02:34Z

Hi @sidolov, thank you for the review.
ENGCOM-4788 has been created to process this Pull Request

VasylShvorak · 2019-05-02T11:59:12Z

✔️ QA passed

m2-assistant · 2019-05-06T14:53:08Z

Hi @sudhanshu-bajaj, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

…22406 #22423

ghost · 2019-05-09T03:27:15Z

@magento-engcom-team give me 2.3-develop instance

magento-engcom-team · 2019-05-09T03:27:17Z

Hi @sanjaychouhan-webkul. Thank you for your request. I'm working on Magento 2.3-develop instance for you

magento-engcom-team · 2019-05-09T03:28:02Z

Hi @sanjaychouhan-webkul, here is your Magento instance.
Admin access: https://i-22423-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

ghost · 2019-05-09T03:43:05Z

@VladimirZaets @Karlasa @sudhanshu-bajaj issue still not fixed properly, still it is -7px in left.

Please check #22738 I had solved this

Store view specific labels cut in left navigation menu magento#22406

2b60b9f

magento-engcom-team added Area: Design/Frontend Release Line: 2.3 labels Apr 19, 2019

Karlasa self-assigned this Apr 19, 2019

sudhanshu-bajaj self-assigned this Apr 19, 2019

ghost unassigned sudhanshu-bajaj Apr 19, 2019

sudhanshu-bajaj added the Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release label Apr 19, 2019

Karlasa self-requested a review April 19, 2019 11:12

Karlasa approved these changes Apr 19, 2019

View reviewed changes

ghost added the Progress: ready for testing label Apr 19, 2019

sudhanshu-bajaj mentioned this pull request Apr 21, 2019

Store view specific labels cut in left navigation menu #22406

Closed

VasylShvorak self-assigned this Apr 22, 2019

AlexWorking self-assigned this Apr 22, 2019

ghost unassigned AlexWorking Apr 22, 2019

ghost added Progress: testing in progress and removed Progress: ready for testing labels Apr 22, 2019

p-bystritsky self-assigned this Apr 23, 2019

ghost added Progress: accept and removed Progress: extended testing labels Apr 23, 2019

magento-engcom-team added the Cleanup label Apr 23, 2019

VladimirZaets requested changes Apr 23, 2019

View reviewed changes

ghost assigned VladimirZaets Apr 23, 2019

ghost added Progress: needs update and removed Progress: accept labels Apr 23, 2019

sidolov approved these changes Apr 30, 2019

View reviewed changes

ghost assigned sidolov Apr 30, 2019

ghost added Progress: ready for testing and removed Progress: needs update labels Apr 30, 2019

ghost added Progress: testing in progress and removed Progress: ready for testing labels May 2, 2019

ghost added Progress: extended testing Progress: accept and removed Progress: testing in progress Progress: extended testing labels May 2, 2019

magento-engcom-team merged commit 2b60b9f into magento:2.3-develop May 6, 2019

magento-engcom-team pushed a commit that referenced this pull request May 6, 2019

ENGCOM-4788: Store view specific labels cut in left navigation menu #…

e4c9638

…22406 #22423

magento-engcom-team added this to the Release: 2.3.3 milestone May 6, 2019

This was referenced May 7, 2019

issue #22706 #19647 fixed #22714

Closed

Backend Marketing Store View Specific Labels Options Label not aligned #19647

Closed

Store view specific labels cut in left navigation menu #22406 #22423

Store view specific labels cut in left navigation menu #22406 #22423

Conversation

sudhanshu-bajaj commented Apr 19, 2019 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Preconditions (*)

Steps to reproduce (*)

Expected result (*)

Actual result (*)

Uh oh!

m2-assistant bot commented Apr 19, 2019

Uh oh!

Karlasa commented Apr 19, 2019

Uh oh!

magento-engcom-team commented Apr 19, 2019

Uh oh!

magento-engcom-team commented Apr 19, 2019

Uh oh!

Karlasa commented Apr 19, 2019

Uh oh!

magento-engcom-team commented Apr 19, 2019

Uh oh!

magento-engcom-team commented Apr 19, 2019

Uh oh!

ghost commented Apr 19, 2019

Uh oh!

Karlasa commented Apr 19, 2019

Uh oh!

magento-engcom-team commented Apr 19, 2019

Uh oh!

magento-engcom-team commented Apr 19, 2019

Uh oh!

magento-engcom-team commented Apr 19, 2019

Uh oh!

ghost commented Apr 22, 2019

Uh oh!

VasylShvorak commented Apr 22, 2019

Uh oh!

VladimirZaets Apr 23, 2019

Choose a reason for hiding this comment

Uh oh!

sudhanshu-bajaj Apr 24, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sudhanshu-bajaj Apr 28, 2019

Choose a reason for hiding this comment

Uh oh!

magento-engcom-team commented Apr 30, 2019

Uh oh!

VasylShvorak commented May 2, 2019

Uh oh!

m2-assistant bot commented May 6, 2019

Uh oh!

ghost commented May 9, 2019

Uh oh!

magento-engcom-team commented May 9, 2019

Uh oh!

magento-engcom-team commented May 9, 2019

Uh oh!

ghost commented May 9, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

sudhanshu-bajaj commented Apr 19, 2019 •

edited by ghost

Loading

sudhanshu-bajaj Apr 24, 2019 •

edited

Loading