-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Fixes issue #13227 #22650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes issue #13227 #22650
Conversation
|
Hi @atishgoswami. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
|
@magento-engcom-team give me test instance |
|
Hi @atishgoswami. Thank you for your request. I'm working on Magento instance for you |
|
Hi @atishgoswami, here is your new Magento instance. |
|
That's a very good point. If the corresponding configuration is not enabled, the system should not take into account a category ID |
|
Seems like were couple unrelated test that seems to be broken. |
|
Hi @atishgoswami. Sorry for the delayed answer. I believe the failing integration tests are related to the current PR. The system expects URL to have a category in the path but gets direct URL to the project. We need to adjust the tests correspondingly. |
orlangur
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Your PR already includes my notes from https://github.com/magento/magento2/pull/22322/files#r275178147 :)
Please remove redundant parentheses, adopt existing integration tests and add a new one corresponding to described case.
After changes are applied and all builds are green, please squash them into a single commit so that we have perfectly clean history 😉
|
Hi @sidolov, thank you for the review.
|
|
✔️ QA Passed |
|
Hi @atishgoswami, thank you for your contribution! |
Description
Recently Viewed contains wrong product url with category path
This PR will:
Fixed Issues (if relevant)
#13227
Contribution checklist