Skip to content

#13227 Wrong product url (with category path) was fixed. #22322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
andrewbess wants to merge 1 commit into from
Closed

#13227 Wrong product url (with category path) was fixed. #22322

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/code/Magento/Catalog/Model/Product/Url.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,9 +162,9 @@ public function getUrl(\Magento\Catalog\Model\Product $product, $params = [])
\Magento\Store\Model\ScopeInterface::SCOPE_STORE
);

if ($categoryId) {
if ($useCategories && $categoryId) {
$filterData[UrlRewrite::METADATA]['category_id'] = $categoryId;
} elseif (!$useCategories) {
} else {
$filterData[UrlRewrite::METADATA]['category_id'] = '';
Copy link
Contributor

@orlangur orlangur Apr 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rewrite as ternary operator instead.

QA Note: f47347f issue needs to be rechecked

Copy link
Contributor

@orlangur orlangur Apr 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrewbess also, please implement an integration test for corresponding scenario.

Copy link
Contributor Author

@andrewbess andrewbess Apr 15, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@orlangur Ok. Thank you.

}

Expand Down