Skip to content

Allow to disable module via installer using enable_modules = all #20904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Allow to disable module via installer using enable_modules = all #20904

wants to merge 1 commit into from

Conversation

realadityayadav
Copy link
Member

@realadityayadav realadityayadav commented Feb 3, 2019

Fixed #14143

Description (*)

Allow to disable module via installer using enable_modules = all

Fixed Issues (if relevant)

  1. Allow to disable module via installer using enable_modules = all #14143: Allow to disable module via installer using enable_modules = all

Manual testing scenarios (*)

  1. Use a cli command to install magento with option enable_modules = all and disable_module
bin/magento setup:install --base-url=http://magento.local/ \
--db-host=localhost --db-name=magento --db-user=root --db-password=root \
--admin-firstname=admin --admin-lastname=admin [email protected] \
--admin-user=admin --admin-password=example@password1 --language=en_US \
--use-rewrites=1 --backend-frontname admin \
--enable-modules='all' --disable-modules='Magento_Sitemap'

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @adityayadav-cedcoss. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@sivaschenko
Copy link
Member

Hi @realadityayadav thanks for the pull request! There were integration test failures on the original pull request: #14144 . Can you confirm that all integaration tests are passing on this PR?

@sivaschenko sivaschenko self-assigned this Feb 6, 2019
@sivaschenko
Copy link
Member

Hi @realadityayadav , I am closing this PR due to inactivity. Feel free to contact me in case you'd like to continue progress on this pull request.

@sivaschenko sivaschenko closed this Apr 1, 2019
@m2-assistant
Copy link

m2-assistant bot commented Apr 1, 2019

Hi @realadityayadav, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@realadityayadav realadityayadav deleted the aditya-issue-fix-14143 branch February 2, 2020 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow to disable module via installer using enable_modules = all
4 participants