Skip to content

[issues/14143] Allow to disable module via installer using enable_mod… #14144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

PascalBrouwers
Copy link
Contributor

…ules = all

Description

When installing via the installer you can use the options disable_modules and enable_modules
How it works now is that you need to list all modules in the enable_modules list if you want to be able to disable a module for install.

Fixed Issues (if relevant)

  1. Allow to disable module via installer using enable_modules = all #14143: Allow to disable module via installer using enable_modules = all

Manual testing scenarios

See: #14143

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team magento-engcom-team added this to the March 2018 milestone Mar 19, 2018
@magento-engcom-team
Copy link
Contributor

Hi @miguelbalparda, thank you for the review.
ENGCOM-966 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

@PascalBrouwers thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@okorshenko okorshenko modified the milestones: March 2018, April 2018 Apr 16, 2018
@magento-engcom-team magento-engcom-team added Partner: Reach Digital Pull Request is created by partner Reach Digital partners-contribution Pull Request is created by Magento Partner labels Apr 20, 2018
@magento-engcom-team
Copy link
Contributor

Hi @miguelbalparda, thank you for the review.
ENGCOM-966 has been created to process this Pull Request

@okorshenko okorshenko modified the milestones: April 2018, May 2018 May 18, 2018
@okorshenko okorshenko removed this from the May 2018 milestone May 31, 2018
@miguelbalparda
Copy link
Contributor

@PascalBrouwers can you please sign the CLA?

@ishakhsuvarov ishakhsuvarov added this to the Release: 2.3.1 milestone Sep 18, 2018
@PascalBrouwers
Copy link
Contributor Author

@miguelbalparda I already signed the CLA. Can we move this PR forward?

@sivaschenko
Copy link
Member

Hi @PascalBrouwers , Magento_Developer and Magento_Setup integration tests are failing on this pull request. Can you please update your branch and fix the integration tests.

@sivaschenko
Copy link
Member

Hi @PascalBrouwers , would you like to continue the progress on this PR?

@sidolov
Copy link
Contributor

sidolov commented Dec 4, 2018

Hi @PascalBrouwers , I am closing this PR now due to inactivity.
Please reopen and update if you wish to continue.
Thank you for the collaboration!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Setup Partner: H&O Partner: Reach Digital Pull Request is created by partner Reach Digital partners-contribution Pull Request is created by Magento Partner Progress: needs update Release Line: 2.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants