Skip to content

[Backport] Use the new json serializer which throws an error when failing #20271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
magento-engcom-team merged 5 commits into from
Jan 18, 2019
Merged

[Backport] Use the new json serializer which throws an error when failing #20271

magento-engcom-team merged 5 commits into from
Jan 18, 2019

Conversation

@quisse
Copy link

@quisse quisse commented Jan 14, 2019

Original Pull Request

#16154

Description

Use the new serializer which throws an error when json_encoding fails.

Fixed Issues (if relevant)

  1. Javascript error thrown from uiComponent 'notification_area' if messages are malformed #14937: Javascript error thrown from uiComponent 'notification_area' if messages are malformed
  2. Perhaps more

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Tommy Quissens and others added 3 commits January 14, 2019 11:54
added json hex tag serializer and use it.
7e3ea1b 
code formatting

Backwards compatibility fix

use JSON_HEX_TAG option for not breaking things

use new serializer instead of json_encode

use correct serializer in test

declare return type

use serializer

updated unit testing, now uses serializer

removed space

declare strict type

improved comment

Test new serializer

Test for greater than and lesser than symbol, required by JSON_HEX_TAG option

split comment for readability

Declare strict type on test

Use di to inject

cleanup curly brackets

code cleanup

removed empty phpdoc

Fix BC
@nmalevanec
Fix static tests.
f72fb42
@nmalevanec
Fix static test.
dbb905c
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Jan 14, 2019

Hi @quisse. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@quisse quisse mentioned this pull request Jan 14, 2019
Closed
4 tasks
@VladimirZaets VladimirZaets self-assigned this Jan 14, 2019
@magento-engcom-team magento-engcom-team added this to the Release: 2.2.8 milestone Jan 14, 2019
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Jan 14, 2019

Hi @VladimirZaets, thank you for the review.
ENGCOM-3858 has been created to process this Pull Request

@quisse
Copy link
Author

quisse commented Jan 14, 2019

Where can I find/reproduce the breaking test? Can't find it

@magento-engcom-team magento-engcom-team mentioned this pull request Jan 18, 2019
Closed
@ghost
Copy link

ghost commented Jan 18, 2019

Hi @quisse, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team merged commit 31bf4b2 into magento:2.2-develop Jan 18, 2019
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Jan 18, 2019

Hi @quisse. Thank you for your contribution.
We will aim to release these changes as part of 2.2.8.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

@quisse quisse deleted the 2.2-develop-PR-port-16154 branch January 21, 2019 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@VladimirZaets VladimirZaets VladimirZaets approved these changes

Assignees

@VladimirZaets VladimirZaets

Labels

Component: Checkout Component: Framework/Serialize Component: Ui Release Line: 2.2

Projects

None yet

Milestone

Release: 2.2.8

Development

Successfully merging this pull request may close these issues.

4 participants

@quisse @magento-engcom-team @VladimirZaets @nmalevanec