Use the new json serializer which throws an error when failing #16154

quisse · 2018-06-15T08:56:46Z

Description

Use the new serializer which throws an error when json_encoding fails.

Fixed Issues (if relevant)

Javascript error thrown from uiComponent 'notification_area' if messages are malformed #14937: Javascript error thrown from uiComponent 'notification_area' if messages are malformed
Perhaps more

Contribution checklist

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds on Travis CI are green)

magento-cicd2 · 2018-06-15T08:56:49Z

All committers have signed the CLA.

magento-engcom-team · 2018-06-15T08:56:53Z

Hi @quisse. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento-engcom-team give me test instance - deploy test instance based on Pull Request changes
@magento-engcom-team give me new test instance - deploy NEW test instance based on Pull Request changes
@magento-engcom-team give me {$VERSION} instance - deploy Vanilla Magento instance for Issue or Pull Request

For more details, please, review the Magento Contributor Assistant documentation

quisse · 2018-06-15T08:58:23Z

@magento-engcom-team give me test instance

magento-engcom-team · 2018-06-15T08:58:27Z

Hi @quisse. Thank you for your request.\nUnfortunately, I can only deploy instances for 2.2-develop and 2.3-develop base branches

quisse · 2018-06-15T10:01:08Z

@umarch06 @magento-engcom-team any idea why the test instance can't be created?

ishakhsuvarov · 2018-06-18T11:07:30Z

@magento-engcom-team give me test instance

magento-engcom-team · 2018-06-18T11:07:31Z

Hi @ishakhsuvarov. Thank you for your request. I'm working on Magento instance for you

magento-engcom-team · 2018-06-18T11:08:02Z

Hi @ishakhsuvarov, here is your Magento instance.
Admin access: https://pr-16154.engcom.dev.magento.com/admin
Login: admin Password: 123123q
Please make sure you are PR author or assignee to access the instance.

app/code/Magento/Ui/TemplateEngine/Xhtml/Result.php

quisse · 2018-06-18T13:22:29Z

Edited

quisse

Any idea what to do for bc with the Onepage Block?

quisse · 2018-06-19T09:34:38Z

& any idea why travis isn't building anything?

ihor-sviziev · 2018-06-22T13:01:54Z

@quisse looks like travis built your build, please review failures

quisse · 2018-06-22T13:10:58Z

Finally 😄, i'll review asap.

ihor-sviziev · 2018-06-26T07:49:20Z

Hi @quisse,
your changes looks good. Could you squash them into single commit and force push layout-config-serializer-fix branch?

ihor-sviziev

Your changes looks good. Could you squash them into single commit and force push layout-config-serializer-fix branch?

lib/internal/Magento/Framework/Serialize/Serializer/JsonHexTag.php

lib/internal/Magento/Framework/Serialize/Test/Unit/Serializer/JsonHexTagTest.php

sivaschenko

Please see the review notes

app/code/Magento/Checkout/Block/Onepage.php

lib/internal/Magento/Framework/Serialize/Serializer/JsonHexTag.php

quisse · 2018-11-20T10:19:11Z

I'll squash when the pr is ready for approval

sivaschenko

Thanks for collaboration. Please see the review notes

app/code/Magento/Checkout/Block/Onepage.php

app/code/Magento/Checkout/etc/frontend/di.xml

lib/internal/Magento/Framework/Serialize/Serializer/JsonHexTag.php

lib/internal/Magento/Framework/Serialize/Test/Unit/Serializer/JsonHexTagTest.php

sivaschenko

Thanks for updates, I do not have any comments except adding some comment to empty phpdoc, please add it and squash changes for the delivery.

lib/internal/Magento/Framework/Serialize/Test/Unit/Serializer/JsonHexTagTest.php

magento-engcom-team · 2018-11-30T10:32:40Z

Hi @sivaschenko, thank you for the review.
ENGCOM-3598 has been created to process this Pull Request

code formatting Backwards compatibility fix use JSON_HEX_TAG option for not breaking things use new serializer instead of json_encode use correct serializer in test declare return type use serializer updated unit testing, now uses serializer removed space declare strict type improved comment Test new serializer Test for greater than and lesser than symbol, required by JSON_HEX_TAG option split comment for readability Declare strict type on test Use di to inject cleanup curly brackets code cleanup removed empty phpdoc Fix BC

…g-serializer-fix

ghost · 2019-01-14T11:46:34Z

Hi @quisse, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team · 2019-01-14T11:47:10Z

Hi @quisse. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

…ailing #16154

magento-engcom-team added the Component: Ui label Jun 15, 2018

sidolov requested changes Jun 18, 2018

View reviewed changes

app/code/Magento/Ui/TemplateEngine/Xhtml/Result.php Outdated Show resolved Hide resolved

sidolov added the Progress: needs update label Jun 18, 2018

quisse commented Jun 19, 2018

View reviewed changes

ihor-sviziev self-assigned this Jun 26, 2018

ihor-sviziev requested changes Jun 26, 2018

View reviewed changes

quisse force-pushed the layout-config-serializer-fix branch from 0734673 to 3bedbc6 Compare June 26, 2018 08:20

quisse changed the title ~~Use the new json serializer which throws an error when failing~~ [Forwardport] Use the new json serializer which throws an error when failing Jun 26, 2018

quisse changed the title ~~[Forwardport] Use the new json serializer which throws an error when failing~~ Use the new json serializer which throws an error when failing Jun 26, 2018

quisse mentioned this pull request Jun 26, 2018

[Backport 2.2] Use the new json serializer which throws an error when failing #16395

Closed

4 tasks

ishakhsuvarov reviewed Jun 26, 2018

View reviewed changes

lib/internal/Magento/Framework/Serialize/Serializer/JsonHexTag.php Outdated Show resolved Hide resolved

ishakhsuvarov reviewed Jun 26, 2018

View reviewed changes

lib/internal/Magento/Framework/Serialize/Serializer/JsonHexTag.php Outdated Show resolved Hide resolved

ishakhsuvarov reviewed Jun 26, 2018

View reviewed changes

lib/internal/Magento/Framework/Serialize/Serializer/JsonHexTag.php Outdated Show resolved Hide resolved

ishakhsuvarov reviewed Jun 26, 2018

View reviewed changes

lib/internal/Magento/Framework/Serialize/Serializer/JsonHexTag.php Outdated Show resolved Hide resolved

ihor-sviziev requested changes Jun 26, 2018

View reviewed changes

lib/internal/Magento/Framework/Serialize/Test/Unit/Serializer/JsonHexTagTest.php Outdated Show resolved Hide resolved

ihor-sviziev assigned ishakhsuvarov Jul 3, 2018

ishakhsuvarov added the Progress: on hold label Jul 12, 2018

orlangur removed the Progress: on hold label Nov 7, 2018

sivaschenko requested changes Nov 19, 2018

View reviewed changes

app/code/Magento/Checkout/Block/Onepage.php Outdated Show resolved Hide resolved

lib/internal/Magento/Framework/Serialize/Serializer/JsonHexTag.php Outdated Show resolved Hide resolved

sivaschenko self-assigned this Nov 19, 2018

sivaschenko added the Progress: needs update label Nov 19, 2018

sivaschenko requested changes Nov 20, 2018

View reviewed changes

lib/internal/Magento/Framework/Serialize/Test/Unit/Serializer/JsonHexTagTest.php Outdated Show resolved Hide resolved

quisse force-pushed the layout-config-serializer-fix branch from 9ca1c94 to b7ba2bd Compare November 20, 2018 18:25

ishakhsuvarov removed their assignment Nov 30, 2018

sivaschenko approved these changes Nov 30, 2018

View reviewed changes

sivaschenko removed the Progress: needs update label Nov 30, 2018

magento-engcom-team added Component: Checkout Component: Ui labels Nov 30, 2018

quisse force-pushed the layout-config-serializer-fix branch from b7ba2bd to da7f293 Compare December 3, 2018 16:41

nmalevanec added 2 commits January 3, 2019 11:12

Merge remote-tracking branch 'mainline/2.3-develop' into layout-confi…

d7a11d7

…g-serializer-fix

Fix static tests.

46a9ed5

sivaschenko mentioned this pull request Jan 3, 2019

[Up port] Fixed the issue #19347. #19393

Closed

4 tasks

nmalevanec added 2 commits January 3, 2019 17:00

Fix static test.

32fd4bd

Merge remote-tracking branch 'mainline/2.3-develop' into layout-confi…

bea49bc

…g-serializer-fix

magento-engcom-team added the Progress: accept label Jan 8, 2019

magento-engcom-team merged commit bea49bc into magento:2.3-develop Jan 14, 2019

magento-engcom-team added the Award: bug fix label Jan 14, 2019

magento-engcom-team pushed a commit that referenced this pull request Jan 14, 2019

ENGCOM-3598: Use the new json serializer which throws an error when f…

adf4e6e

…ailing #16154

This was referenced Jan 14, 2019

[Backport] Use the new json serializer which throws an error when failing quisse/magento2#3

Closed

[Backport] Use the new json serializer which throws an error when failing #20271

Merged

quisse deleted the layout-config-serializer-fix branch January 21, 2019 07:12

Use the new json serializer which throws an error when failing #16154

Use the new json serializer which throws an error when failing #16154

Uh oh!

Conversation

quisse commented Jun 15, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Fixed Issues (if relevant)

Contribution checklist

Uh oh!

magento-cicd2 commented Jun 15, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

magento-engcom-team commented Jun 15, 2018

Uh oh!

quisse commented Jun 15, 2018

Uh oh!

magento-engcom-team commented Jun 15, 2018

Uh oh!

quisse commented Jun 15, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ishakhsuvarov commented Jun 18, 2018

Uh oh!

magento-engcom-team commented Jun 18, 2018

Uh oh!

magento-engcom-team commented Jun 18, 2018

Uh oh!

Uh oh!

quisse commented Jun 18, 2018

Uh oh!

quisse left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

quisse commented Jun 19, 2018

Uh oh!

ihor-sviziev commented Jun 22, 2018

Uh oh!

quisse commented Jun 22, 2018

Uh oh!

ihor-sviziev commented Jun 26, 2018

Uh oh!

ihor-sviziev left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sivaschenko left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

quisse commented Nov 20, 2018

Uh oh!

sivaschenko left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sivaschenko left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

magento-engcom-team commented Nov 30, 2018

Uh oh!

ghost commented Jan 14, 2019

Uh oh!

magento-engcom-team commented Jan 14, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

quisse commented Jun 15, 2018 •

edited

Loading

magento-cicd2 commented Jun 15, 2018 •

edited

Loading

quisse commented Jun 15, 2018 •

edited

Loading

quisse left a comment •

edited

Loading