Skip to content

[Backport] fixed Notification page Select Visible items issue #19910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
magento-engcom-team merged 15 commits into from
Jan 4, 2019
Merged

[Backport] fixed Notification page Select Visible items issue #19910

Changes from 14 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
9804da7
fixed store wise product filter issue
Nov 1, 2018
c4bf9d2
Update AbstractCollection.php
Nov 21, 2018
9e37895
fixed Notification page Select Visible items issue
Nov 21, 2018
b39a770
updated AbstractMassaction
Nov 23, 2018
c0ea9e4
Updated AbstractCollection.php
Nov 23, 2018
0810a4a
Updated AbstractMassaction.php
Nov 23, 2018
a69b2d9
Updated AbstractCollection.php
Nov 23, 2018
598881f
Updated AbstractMassaction.php
Nov 28, 2018
84461c5
Updated AbstractCollection.php
Nov 28, 2018
8397479
Updated AbstractMassaction.php
Nov 28, 2018
3808266
ENGCOM-3588: Static tests fix.
p-bystritsky Dec 6, 2018
108b190
Updated AbstractMassaction.php
Dec 21, 2018
25a6c2e
Updated AbstractMassaction.php
Dec 21, 2018
4fd5c95
updated phpdocs changes
Dec 27, 2018
2c55232
Fixed code style issue
sidolov Jan 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 16 additions & 3 deletions app/code/Magento/Backend/Block/Widget/Grid/Massaction/AbstractMassaction.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
namespace Magento\Backend\Block\Widget\Grid\Massaction;

use Magento\Backend\Block\Widget\Grid\Massaction\VisibilityCheckerInterface as VisibilityChecker;
use Magento\Framework\Data\Collection\AbstractDb;
use Magento\Framework\DataObject;

/**
Expand Down Expand Up @@ -51,7 +52,7 @@ public function __construct(
}

/**
* @return void
* @inheritdoc
*/
protected function _construct()
{
Expand Down Expand Up @@ -214,8 +215,9 @@ public function getGridJsObjectName()

/**
* Retrieve JSON string of selected checkboxes
*
*
* @return string
* @SuppressWarnings(PHPMD.RequestAwareBlockMethod)
*/
public function getSelectedJson()
{
Expand All @@ -230,6 +232,7 @@ public function getSelectedJson()
* Retrieve array of selected checkboxes
*
* @return string[]
* @SuppressWarnings(PHPMD.RequestAwareBlockMethod)
*/
public function getSelected()
{
Expand All @@ -251,6 +254,8 @@ public function getApplyButtonHtml()
}

/**
* Get mass action javascript code.
*
* @return string
*/
public function getJavaScript()
Expand All @@ -267,6 +272,8 @@ public function getJavaScript()
}

/**
* Get grid ids in JSON format.
*
* @return string
*/
public function getGridIdsJson()
Expand All @@ -282,7 +289,11 @@ public function getGridIdsJson()
} else {
$massActionIdField = $this->getParentBlock()->getMassactionIdField();
}

if ($allIdsCollection instanceof AbstractDb) {
$allIdsCollection->getSelect()->limit();
$allIdsCollection->clear();
}

$gridIds = $allIdsCollection->setPageSize(0)->getColumnValues($massActionIdField);
if (!empty($gridIds)) {
return join(",", $gridIds);
Expand All @@ -291,6 +302,8 @@ public function getGridIdsJson()
}

/**
* Get Html id.
*
* @return string
*/
public function getHtmlId()
Expand Down