-
Notifications
You must be signed in to change notification settings - Fork 9.4k
[Backport] fixed Notification page Select Visible items issue #19910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport] fixed Notification page Select Visible items issue #19910
Conversation
Fixed issue - #18374 Unable to get product attribute value for store-view scope type in product collection loaded for a specific store.
Fixed issue - magento #19285 On Notification page Select All and Select Visible both works same
reverted changes
added getColumnValues function in collection for getting all values with reset limits
called new function named getAllColumnValues for getting all collection values for specific field
Added new function i.e getAllColumnValues which reset current collection limits/orders and returns all values from collection for specific field in array
|
Hi @shikhamis11. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
|
Hi @shikhamis11, thanks for collaboration. Please update |
|
@VladimirZaets I have updated changes please check |
|
Hi @sidolov, thank you for the review. |
|
Hi @shikhamis11, thank you for your contribution! |
|
Hi @shikhamis11. Thank you for your contribution. Please, consider to port this solution to 2.3 release line. |
Original Pull Request
#19302
Fixed issue - #19285
On Notification page Select All and Select Visible both works same
Description (*)
Fixed issue #19285 On Notification page Select All and Select Visible both works same
Fixed Issues (if relevant)
#19285 On Notification page Select All and Select Visible both works same
Manual testing scenarios (*)
Contribution checklist (*)