Skip to content

Conversation

@shikhamis11
Copy link
Member

Original Pull Request

#19302
Fixed issue - #19285
On Notification page Select All and Select Visible both works same

Description (*)

Fixed issue #19285 On Notification page Select All and Select Visible both works same

Fixed Issues (if relevant)

#19285 On Notification page Select All and Select Visible both works same

Manual testing scenarios (*)

  1. Login to Magento Admin.
  2. Select Notifications (Bell Icon from right top of the screen).
  3. Click on "See All".
  4. Default paging is set to 20 rows per page.
  5. Make sure you have more than 20 notifications so that you can have paging available and some notification are on next pages.
  6. Now from Mass Action dropdown select "Select All" action. This will select only visible notifications (currently 20, as 20 rows per page is setup) instead of all available records.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

shikhamis11 and others added 11 commits December 20, 2018 17:34
Fixed issue - #18374
Unable to get product attribute value for store-view scope type in product collection loaded for a specific store.
Fixed issue - magento #19285
On Notification page Select All and Select Visible both works same
reverted changes
added getColumnValues function  in collection for getting all values with reset limits
called new function named getAllColumnValues for getting all collection values for specific field
Added new function i.e getAllColumnValues which reset current collection limits/orders and returns all values from collection for specific field in array
@magento-engcom-team
Copy link
Contributor

Hi @shikhamis11. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@VladimirZaets
Copy link
Contributor

Hi @shikhamis11, thanks for collaboration. Please update phpdocs declaration how it was updated in the original PR.

@shikhamis11
Copy link
Member Author

@VladimirZaets I have updated changes please check

@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-3777 has been created to process this Pull Request

@ghost
Copy link

ghost commented Jan 4, 2019

Hi @shikhamis11, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team
Copy link
Contributor

Hi @shikhamis11. Thank you for your contribution.
We will aim to release these changes as part of 2.2.8.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants