🔃 [EngCom] Public Pull Requests - 2.3-develop

Accepted Public Pull Requests:
 - #19868: Fix travis tests on 2.3-develop branch (by @ihor-sviziev)
 - #19788: [Forwardport] Fixed - Shipping issue on PayPal Express #14712 (by @ssp58bleuciel)
 - #19824: magento/magento2#?: Mark not used blocks, controllers and layout updates which are related to deprecated way of rendering grid for related/coross-sell/upsell products. (by @swnsma)
 - #19751: Fixed #19605 Don't static compile disabled modules (by @shikhamis11)
 - #19784: Fixed  Incorrect class name on Orders and returns page. (by @shikhamis11)
 - #19768: fixed Typo error  assoctiated -> associated (by @jitendra-cedcoss)
 - #19770: Typo taax -> tax (by @akshayadixit)
 - #19764: Correct location of transparent.js (by @pmclain)
 - #19707:  PaymentTokenRepositoryInterface: missing setTotalCount in getList() method (by @textarea)
 - #19341: [Forwardport] Creating custom customer attribute with default value 0 will cause not saving value for customer entity. (by @nmalevanec)
 - #19709: Add useful debug info for which website has not been found (by @craigcarnell)
 - #19663: Fixed Click for price in home page not work #15922 (by @ravi-chandra3197)
 - #18895: added config for catalog review in frontend (by @torhoehn)
 - #19387: [Forwardport]Fixed - Default tax region/state appears in customer & order data (by @ssp58bleuciel)
 - #19402: make sure that the removal of the custom_price is properly persisted into database (by @godvsdeity)
 - #19094: 19085-Translation-in-tier-price-phtml-not-working (by @agorbulin)
 - #19124: bug-fix #16074 - Fix theme change in middle of product page. (by @drew7721)
 - #19104: fix cipherMethod detection for openssl 1.1.1 (by @BlackIkeEagle)
 - #18179: Fix the issue with reset password when customer has address from not allowed country (by @dmytro-ch)


Fixed GitHub Issues:
 - #14712: Shipping issue on PayPal Express (reported by @raymond62) has been fixed in #19788 by @ssp58bleuciel in 2.3-develop branch
   Related commits:
     1. 0e8ffeb
     2. a390390

 - #19605: Don't static compile disabled modules (reported by @joshuaadickerson) has been fixed in #19751 by @shikhamis11 in 2.3-develop branch
   Related commits:
     1. 83f8e98

 - #19780: Incorrect class name on Orders and returns page. (reported by @denis-g) has been fixed in #19784 by @shikhamis11 in 2.3-develop branch
   Related commits:
     1. 05f335f

 - #19763: Admin Sales Order Create Fails with PayflowPro (reported by @pmclain) has been fixed in #19764 by @pmclain in 2.3-develop branch
   Related commits:
     1. 8e5c631
     2. fd2200a

 - #19706: PaymentTokenRepositoryInterface: missing setTotalCount in getList() method (reported by @textarea) has been fixed in #19707 by @textarea in 2.3-develop branch
   Related commits:
     1. 0a2330a
     2. eb62681

 - #14510: Creating custom customer attribute with default value 0 will cause not saving value for customer entity (reported by @victortodoran) has been fixed in #19341 by @nmalevanec in 2.3-develop branch
   Related commits:
     1. fb19f3f

 - #15922: Click for price in home page can`t work (reported by @michaeldyl520) has been fixed in #19663 by @ravi-chandra3197 in 2.3-develop branch
   Related commits:
     1. f073859
     2. d116aec
     3. 37b2eb6
     4. 68636ec

 - #16684: Default tax region/state appears in customer & order data (reported by @Detzler) has been fixed in #19387 by @ssp58bleuciel in 2.3-develop branch
   Related commits:
     1. 350b56c
     2. 2854a1e
     3. 01d4bd6
     4. 5638333
     5. 60005f2

 - #19085: Translation in tier_price.phtml not working (reported by @DanieliMi) has been fixed in #19094 by @agorbulin in 2.3-develop branch
   Related commits:
     1. 425514b
     2. 345393d
     3. 63bbc39
     4. 1a006b3

 - #7503: Category design / theme update not inheriting correctly on product pages (reported by @pascaladriaansen) has been fixed in #19124 by @drew7721 in 2.3-develop branch
   Related commits:
     1. 1becee9
     2. b8940db
     3. fd26b94
     4. 47e42a9
     5. 4b6100d
     6. b8442a1

 - #7710: Custom theme doesn't apply XML layout updates when applied to a product (reported by @chickenland) has been fixed in #19124 by @drew7721 in 2.3-develop branch
   Related commits:
     1. 1becee9
     2. b8940db
     3. fd26b94
     4. 47e42a9
     5. 4b6100d
     6. b8442a1

 - #8333: Magento v2.1.2 - Choosing a child theme for product page (reported by @ChevCheusov) has been fixed in #19124 by @drew7721 in 2.3-develop branch
   Related commits:
     1. 1becee9
     2. b8940db
     3. fd26b94
     4. 47e42a9
     5. 4b6100d
     6. b8442a1

 - #14932: Invalid Template with Custom Theme Applied by User Agent (reported by @C0D31GN1T3R) has been fixed in #19124 by @drew7721 in 2.3-develop branch
   Related commits:
     1. 1becee9
     2. b8940db
     3. fd26b94
     4. 47e42a9
     5. 4b6100d
     6. b8442a1

 - #16074: User agent exception not setting the correct templates for product pages. (reported by @drew7721) has been fixed in #19124 by @drew7721 in 2.3-develop branch
   Related commits:
     1. 1becee9
     2. b8940db
     3. fd26b94
     4. 47e42a9
     5. 4b6100d
     6. b8442a1

 - #18170: Unable to reset password if customer has address from not allowed country (reported by @ihor-sviziev) has been fixed in #18179 by @dmytro-ch in 2.3-develop branch
   Related commits:
     1. 030b223
     2. 54b6382
     3. 406d000
     4. ebd39d3
     5. 91275d6
     6. 33e42ac
     7. 97632b3
     8. 338d568

Author: magento-engcom-team

.travis.yml

@@ -64,6 +64,6 @@ script:
 
   # The scripts for grunt/phpunit type tests
   - if [ $TEST_SUITE == "functional" ]; then dev/tests/functional/vendor/phpunit/phpunit/phpunit -c dev/tests/$TEST_SUITE $TEST_FILTER; fi
-  - if [ $TEST_SUITE != "functional" ] && [ $TEST_SUITE != "js"] && [ $TEST_SUITE != "graphql-api-functional" ]; then phpunit -c dev/tests/$TEST_SUITE $TEST_FILTER; fi
+  - if [ $TEST_SUITE != "functional" ] && [ $TEST_SUITE != "js" ] && [ $TEST_SUITE != "graphql-api-functional" ]; then phpunit -c dev/tests/$TEST_SUITE $TEST_FILTER; fi
   - if [ $TEST_SUITE == "js" ]; then grunt $GRUNT_COMMAND; fi
   - if [ $TEST_SUITE == "graphql-api-functional" ]; then phpunit -c dev/tests/api-functional; fi

app/code/Magento/Analytics/Model/Cryptographer.php

@@ -129,7 +129,12 @@ private function getInitializationVector()
      */
     private function validateCipherMethod($cipherMethod)
     {
-        $methods = openssl_get_cipher_methods();
+        $methods = array_map(
+            'strtolower',
+            openssl_get_cipher_methods()
+        );
+        $cipherMethod = strtolower($cipherMethod);
+
         return (false !== array_search($cipherMethod, $methods));
     }
 }

app/code/Magento/Bundle/Controller/Adminhtml/Bundle/Product/Edit/Crosssell.php

@@ -6,6 +6,16 @@
  */
 namespace Magento\Bundle\Controller\Adminhtml\Bundle\Product\Edit;
 
-class Crosssell extends \Magento\Catalog\Controller\Adminhtml\Product\Crosssell
+use Magento\Catalog\Controller\Adminhtml\Product\Crosssell as CatalogCrossel;
+use Magento\Framework\App\Action\HttpPostActionInterface;
+
+/**
+ * Class Crosssell
+ *
+ * @package Magento\Bundle\Controller\Adminhtml\Bundle\Product\Edit
+ * @deprecated Not used since cross-sell products grid moved to UI components.
+ * @see Magento_Catalog::view/adminhtml/ui_component/crosssell_product_listing.xml
+ */
+class Crosssell extends CatalogCrossel implements HttpPostActionInterface
 {
 }

app/code/Magento/Bundle/Controller/Adminhtml/Bundle/Product/Edit/CrosssellGrid.php

@@ -6,6 +6,16 @@
  */
 namespace Magento\Bundle\Controller\Adminhtml\Bundle\Product\Edit;
 
-class CrosssellGrid extends \Magento\Catalog\Controller\Adminhtml\Product\CrosssellGrid
+use Magento\Catalog\Controller\Adminhtml\Product\CrosssellGrid as CatalogCrosssellGrid;
+use Magento\Framework\App\Action\HttpPostActionInterface;
+
+/**
+ * Class CrosssellGrid
+ *
+ * @package Magento\Bundle\Controller\Adminhtml\Bundle\Product\Edit
+ * @deprecated Not used since cross-sell products grid moved to UI components.
+ * @see Magento_Catalog::view/adminhtml/ui_component/crosssell_product_listing.xml
+ */
+class CrosssellGrid extends CatalogCrosssellGrid implements HttpPostActionInterface
 {
 }

app/code/Magento/Bundle/Controller/Adminhtml/Bundle/Product/Edit/Related.php

@@ -6,6 +6,16 @@
  */
 namespace Magento\Bundle\Controller\Adminhtml\Bundle\Product\Edit;
 
-class Related extends \Magento\Catalog\Controller\Adminhtml\Product\Related
+use Magento\Catalog\Controller\Adminhtml\Product\Related as CatalogRelated;
+use Magento\Framework\App\Action\HttpPostActionInterface;
+
+/**
+ * Class Related
+ *
+ * @package Magento\Bundle\Controller\Adminhtml\Bundle\Product\Edit
+ * @deprecated Not used since related products grid moved to UI components.
+ * @see Magento_Catalog::view/adminhtml/ui_component/related_product_listing.xml
+ */
+class Related extends CatalogRelated implements HttpPostActionInterface
 {
 }

app/code/Magento/Bundle/Controller/Adminhtml/Bundle/Product/Edit/RelatedGrid.php

@@ -6,6 +6,16 @@
  */
 namespace Magento\Bundle\Controller\Adminhtml\Bundle\Product\Edit;
 
-class RelatedGrid extends \Magento\Catalog\Controller\Adminhtml\Product\RelatedGrid
+use Magento\Catalog\Controller\Adminhtml\Product\RelatedGrid as CatalogRelatedGrid;
+use Magento\Framework\App\Action\HttpPostActionInterface;
+
+/**
+ * Class RelatedGrid
+ *
+ * @package Magento\Bundle\Controller\Adminhtml\Bundle\Product\Edit
+ * @deprecated Not used since related products grid moved to UI components.
+ * @see Magento_Catalog::view/adminhtml/ui_component/related_product_listing.xml
+ */
+class RelatedGrid extends CatalogRelatedGrid implements HttpPostActionInterface
 {
 }

app/code/Magento/Bundle/Controller/Adminhtml/Bundle/Product/Edit/Upsell.php

@@ -6,6 +6,16 @@
  */
 namespace Magento\Bundle\Controller\Adminhtml\Bundle\Product\Edit;
 
-class Upsell extends \Magento\Catalog\Controller\Adminhtml\Product\Upsell
+use Magento\Catalog\Controller\Adminhtml\Product\Upsell as CatalogUpsell;
+use Magento\Framework\App\Action\HttpPostActionInterface;
+
+/**
+ * Class Upsell
+ *
+ * @package Magento\Bundle\Controller\Adminhtml\Bundle\Product\Edit
+ * @deprecated Not used since upsell products grid moved to UI components.
+ * @see Magento_Catalog::view/adminhtml/ui_component/upsell_product_listing.xml
+ */
+class Upsell extends CatalogUpsell implements HttpPostActionInterface
 {
 }

app/code/Magento/Bundle/Controller/Adminhtml/Bundle/Product/Edit/UpsellGrid.php

@@ -6,6 +6,13 @@
  */
 namespace Magento\Bundle\Controller\Adminhtml\Bundle\Product\Edit;
 
+/**
+ * Class UpsellGrid
+ *
+ * @package Magento\Bundle\Controller\Adminhtml\Bundle\Product\Edit
+ * @deprecated Not used since upsell products grid moved to UI components.
+ * @see Magento_Catalog::view/adminhtml/ui_component/upsell_product_listing.xml
+ */
 class UpsellGrid extends \Magento\Catalog\Controller\Adminhtml\Product\UpsellGrid
 {
 }

app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/Crosssell.php

@@ -10,9 +10,13 @@
 use Magento\Catalog\Model\Product;
 
 /**
+ * Crossel product edit tab
+ *
  * @api
  * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
  * @since 100.0.2
+ * @deprecated Not used since cross-sell products grid moved to UI components.
+ * @see \Magento\Catalog\Ui\DataProvider\Product\Related\CrossSellDataProvider
  */
 class Crosssell extends Extended
 {

app/code/Magento/Catalog/Block/Adminhtml/Product/Edit/Tab/Related.php

@@ -9,8 +9,12 @@
 use Magento\Backend\Block\Widget\Grid\Extended;
 
 /**
+ * Related product edit tab
+ *
  * @api
  * @since 100.0.2
+ * @deprecated Not used since related products grid moved to UI components.
+ * @see \Magento\Catalog\Ui\DataProvider\Product\Related\RelatedDataProvider
  */
 class Related extends Extended
 {