Skip to content

Conversation

@apasare
Copy link
Contributor

@apasare apasare commented Nov 26, 2018

Description (*)

Minor bug fix for 'Custom Price' when creating an order in backend. The 'Custom Price' is not properly reverted back the the original price when you uncheck the checkbox.

Manual testing scenarios (*)

  1. Login into Admin
  2. Go to 'Sales' -> 'Orders' -> 'Create New Order'
  3. Add a product to order
  4. Check the 'Custom Price*' checkbox and fill in the custom price you want in the textbox below the checkbox
  5. Click on 'Update Items and Quantities' to persist the custom price
  6. Uncheck the 'Custom Price*' checkbox and click again on 'Update Items and Quantities', after the ajax request is done you should see the original price, but... do the next step...
  7. Manually refresh the page, and you should see the price being reverted back to the custom price

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @godvsdeity. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@rogyar
Copy link
Contributor

rogyar commented Nov 26, 2018

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @rogyar. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Nov 26, 2018
@magento-engcom-team
Copy link
Contributor

Hi @rogyar, here is your new Magento instance.
Admin access: https://pr-19402.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@magento-engcom-team magento-engcom-team merged commit 89a4076 into magento:2.3-develop Dec 21, 2018
magento-engcom-team pushed a commit that referenced this pull request Dec 21, 2018
@magento-engcom-team
Copy link
Contributor

Hi @godvsdeity. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants