-
Notifications
You must be signed in to change notification settings - Fork 9.4k
PaymentTokenRepositoryInterface: missing setTotalCount in getList() method #19707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PaymentTokenRepositoryInterface: missing setTotalCount in getList() method #19707
Conversation
Missing setTotalCount on $searchResults object in getList method
|
Hi @textarea. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
|
@magento-engcom-team give me test instance |
|
Hi @okorshenko. Thank you for your request. I'm working on Magento instance for you |
|
Hi @okorshenko, here is your new Magento instance. |
|
@magento-engcom-team give me 2.3-develop instance |
|
Hi @okorshenko. Thank you for your request. I'm working on Magento 2.3-develop instance for you |
|
Hi @okorshenko, here is your Magento instance. |
|
Hi @sivaschenko, thank you for the review. |
…n getList() method #19707
|
Hi @textarea. Thank you for your contribution. |
Missing setTotalCount method on \Magento\Vault\Model\PaymentTokenRepository->getList method
Description (*)
added setTotalCount($collection->getSize() on $searchResults return object
Fixed Issues (if relevant)
Manual testing scenarios (*)
/** @var \Magento\Vault\Api\PaymentTokenRepositoryInterface */
echo $this->paymentTokenRepository->getList(
$this->searchCriteriaBuilder->create()
)->getTotalCount();
Contribution checklist (*)