-
Notifications
You must be signed in to change notification settings - Fork 133
MQE-1964: MFTF Helper - Implementation #644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomreece
reviewed
Mar 16, 2020
src/Magento/FunctionalTestingFramework/Test/etc/Actions/customActions.xsd
Show resolved
Hide resolved
tomreece
reviewed
Mar 16, 2020
- fix static tests
- add travis build for functional test execution
- add travis build for functional test execution
- add travis build for functional test execution
- add travis build for functional test execution
soumyau
reviewed
Mar 16, 2020
dev/tests/functional/tests/MFTF/DevDocs/Helper/CustomHelper.php
Outdated
Show resolved
Hide resolved
soumyau
reviewed
Mar 16, 2020
dev/tests/functional/tests/MFTF/DevDocs/Helper/CustomHelper.php
Outdated
Show resolved
Hide resolved
soumyau
reviewed
Mar 16, 2020
dev/tests/functional/tests/MFTF/DevDocs/ActionGroup/DeprecatedCommentActionGroup.xml
Outdated
Show resolved
Hide resolved
jilu1
reviewed
Mar 16, 2020
jilu1
reviewed
Mar 16, 2020
dev/tests/functional/tests/MFTF/DevDocs/ActionGroup/DeprecatedCommentActionGroup.xml
Outdated
Show resolved
Hide resolved
jilu1
reviewed
Mar 16, 2020
dev/tests/functional/tests/MFTF/DevDocs/Test/DeprecatedDevDocsTest.xml
Outdated
Show resolved
Hide resolved
jilu1
reviewed
Mar 16, 2020
src/Magento/FunctionalTestingFramework/Test/Util/ActionObjectExtractor.php
Show resolved
Hide resolved
soumyau
reviewed
Mar 16, 2020
soumyau
reviewed
Mar 16, 2020
jilu1
reviewed
Mar 16, 2020
dev/tests/functional/tests/MFTF/DevDocs/Helper/CustomHelper.php
Outdated
Show resolved
Hide resolved
Please add necessary Dev Docs. |
3daab41
to
83a0658
Compare
- addressed review comments
@jilu1 I created separate ticket for writing documentation to be able to deliver this feature sooner and start Regression of |
jilu1
suggested changes
Mar 16, 2020
dev/tests/functional/tests/MFTF/DevDocs/Helper/CustomHelper.php
Outdated
Show resolved
Hide resolved
jilu1
reviewed
Mar 17, 2020
- addressed review comments
jilu1
approved these changes
Mar 17, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed Issues (if relevant)
Contribution checklist