Skip to content

MQE-1964: MFTF Helper - Implementation #644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Mar 17, 2020
Merged

MQE-1964: MFTF Helper - Implementation #644

merged 11 commits into from
Mar 17, 2020

Conversation

okolesnyk
Copy link
Member

Description

Fixed Issues (if relevant)

  1. magento/magento2-functional-testing-framework#<issue_number>: Issue title
  2. ...

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@coveralls
Copy link

coveralls commented Mar 16, 2020 •
edited
Loading

Coverage Status

Coverage decreased (-0.5%) to 53.722% when pulling 43d34b7 on MQE-1964 into daae38c on develop.

@okolesnyk
MQE-1964: MFTF Helper - Implementation
73a5ad6 
 - fix static tests
@okolesnyk
MQE-1964: MFTF Helper - Implementation
516c88a 
 - add travis build for functional test execution
@okolesnyk
MQE-1964: MFTF Helper - Implementation
345ec25 
 - add travis build for functional test execution
@okolesnyk
MQE-1964: MFTF Helper - Implementation
56d8f3c 
 - add travis build for functional test execution
@okolesnyk
MQE-1964: MFTF Helper - Implementation
4458f0a 
 - add travis build for functional test execution
soumyau
soumyau reviewed Mar 16, 2020
View reviewed changes
soumyau
soumyau reviewed Mar 16, 2020
View reviewed changes
jilu1
jilu1 reviewed Mar 16, 2020
View reviewed changes
soumyau
soumyau reviewed Mar 16, 2020
View reviewed changes
jilu1
jilu1 reviewed Mar 16, 2020
View reviewed changes
@jilu1
Copy link
Contributor

jilu1 commented Mar 16, 2020

Please add necessary Dev Docs.

@okolesnyk okolesnyk force-pushed the MQE-1964 branch 3 times, most recently from 3daab41 to 83a0658 Compare March 16, 2020 22:57
@okolesnyk
MQE-1964: MFTF Helper - Implementation
2d73bdf 
 - addressed review comments
@okolesnyk
Copy link
Member Author

okolesnyk commented Mar 16, 2020 •
edited
Loading

@jilu1 I created separate ticket for writing documentation to be able to deliver this feature sooner and start Regression of MFTF 3.0.0 RC1
Documentation will be created in scope of: https://jira.corp.magento.com/browse/MQE-2034

@okolesnyk okolesnyk requested review from tomreece, soumyau and jilu1 March 16, 2020 23:14
jilu1
jilu1 suggested changes Mar 16, 2020
View reviewed changes
jilu1
jilu1 reviewed Mar 17, 2020
View reviewed changes
@okolesnyk
MQE-1964: MFTF Helper - Implementation
43d34b7 
 - addressed review comments
jilu1
jilu1 approved these changes Mar 17, 2020
View reviewed changes
Copy link
Contributor

@jilu1 jilu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

@okolesnyk okolesnyk merged commit dc324c1 into develop Mar 17, 2020
@okolesnyk okolesnyk deleted the MQE-1964 branch April 30, 2020 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jilu1 jilu1 jilu1 approved these changes

@tomreece tomreece Awaiting requested review from tomreece

@soumyau soumyau Awaiting requested review from soumyau

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@okolesnyk @coveralls @jilu1 @tomreece @soumyau