Skip to content

Commit 43d34b7

Browse files
committed
MQE-1964: MFTF Helper - Implementation
- addressed review comments
1 parent 6d701d8 commit 43d34b7

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

dev/tests/functional/tests/MFTF/DevDocs/Helper/CustomHelper.php

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,9 +35,12 @@ public function goTo(
3535
$bla = 'blaValue',
3636
array $arraysomething = ['key' => 'value', 'test']
3737
) {
38-
print('Hello, this is custom helper which gives an ability to write custom solutions without usage of <executeInSelenium /> and <performOn /> actions.');
38+
print('Hello, this is custom helper which provides an ability to write custom solutions.' . PHP_EOL);
3939
print('string $url = ' . $url . PHP_EOL);
4040
print('$test = ' . $test . PHP_EOL);
41+
print('$bool = ' . $bool . PHP_EOL);
42+
print('$int = ' . $int . PHP_EOL);
43+
print('$float = ' . $float . PHP_EOL);
4144
print('array $module = [' . implode(', ', $module) . ']' . PHP_EOL);
4245
print('$superBla = ' . $superBla . PHP_EOL);
4346
print('$bla = ' . $bla . PHP_EOL);

src/Magento/FunctionalTestingFramework/Util/TestGenerator.php

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -824,14 +824,13 @@ public function generateStepsPhp($actionObjects, $generationScope = TestGenerato
824824
$customActionAttributes['class'],
825825
$customActionAttributes['method']
826826
);
827-
$typesToQuote = ['string', 'float'];
828827
$errors = [];
829828
foreach ($parameters as $parameter) {
830829
if (array_key_exists($parameter['variableName'], $customActionAttributes)) {
831830
$value = $customActionAttributes[$parameter['variableName']];
832831
$arguments[] = $this->addUniquenessFunctionCall(
833832
$value,
834-
in_array($parameter['type'], $typesToQuote) || $parameter['type'] === null
833+
$parameter['type'] === 'string' || $parameter['type'] === null
835834
);
836835
} elseif ($parameter['isOptional']) {
837836
$value = $parameter['optionalValue'];

0 commit comments

Comments
 (0)