Skip to content

Add webserver configuration to docs #496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 25, 2019
Merged

Add webserver configuration to docs #496

merged 3 commits into from
Oct 25, 2019

Conversation

DanieliMi
Copy link
Contributor

Description

New PR for #485. This time branched off master and merge to master

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@DanieliMi DanieliMi mentioned this pull request Oct 25, 2019
Closed
5 tasks
@DanieliMi
Merge remote-tracking branch 'mage/master' into add-webserver-configu…
079e3f5 
…ration-to-docs

# Conflicts:
#	docs/getting-started.md
@DanieliMi
Copy link
Contributor Author

I've resolved the conflicts by merging master into my branch.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.0%) to 53.87% when pulling 079e3f5 on DanieliMi:add-webserver-configuration-to-docs into 2df6ebf on magento:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+1.0%) to 53.87% when pulling 079e3f5 on DanieliMi:add-webserver-configuration-to-docs into 2df6ebf on magento:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.0%) to 53.87% when pulling 079e3f5 on DanieliMi:add-webserver-configuration-to-docs into 2df6ebf on magento:master.

jilu1
jilu1 approved these changes Oct 25, 2019
View reviewed changes
Copy link
Contributor

@jilu1 jilu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Thanks for your contribution!

@KevinBKozan KevinBKozan merged commit f96bbf5 into magento:master Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jilu1 jilu1 jilu1 approved these changes

Assignees
No one assigned
Labels
accept community-contribution DOC
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@DanieliMi @coveralls @jilu1 @KevinBKozan @dobooth