Skip to content

#339 Add information about web server configuration #485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

#339 Add information about web server configuration #485

wants to merge 2 commits into from

Conversation

DanieliMi
Copy link
Contributor

Description

As mentioned in #339 the MFTF doesn't support executing CLI command if the web server points to <MAGE_ROOT_DIR>/pub as recommended in the DevDocs. I added information about it in the docs. It is not mentioned currently and might save other developers some time figuring it out (it would've saved me some time).

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@coveralls
Copy link

coveralls commented Oct 15, 2019

Coverage Status

Coverage decreased (-0.6%) to 52.421% when pulling d0ac05b on DanieliMi:patch-2 into 8ac2937 on magento:develop.

jilu1
jilu1 previously approved these changes Oct 21, 2019
Copy link
Contributor

@jilu1 jilu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This web server configuration note makes sense. Thank you for your contribution!

@DanieliMi
Copy link
Contributor Author

I'll resolve the conflicts soon.

@jilu1 jilu1 added the DOC label Oct 21, 2019
@jilu1
Copy link
Contributor

jilu1 commented Oct 21, 2019

@dobooth Please review from DevDoc side. And do you need PR to master?

@dobooth dobooth changed the base branch from develop to master October 21, 2019 15:11
@dobooth dobooth changed the base branch from master to develop October 21, 2019 15:11
@dobooth
Copy link
Contributor

dobooth commented Oct 21, 2019

Thanks for the contribution, @DanieliMi. We need documentation PRs to point to master, so they can get picked up by our automation systems. Can you please update and rebase this PR to master? Thanks!

@DanieliMi
Copy link
Contributor Author

@dobooth Shall I force push the rebase or create a new branch from master, cherry pick the commits and open a new PR? The problem is my patch branch is from develop.

@dobooth
Copy link
Contributor

dobooth commented Oct 22, 2019

@DanieliMi It probably better to make a new branch from master and cherry pick.

@DanieliMi
Copy link
Contributor Author

@jilu1 @dobooth I created a new PR #496

@DanieliMi DanieliMi closed this Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants