-
Notifications
You must be signed in to change notification settings - Fork 132
#339 Add information about web server configuration #485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This web server configuration note makes sense. Thank you for your contribution!
I'll resolve the conflicts soon. |
@dobooth Please review from DevDoc side. And do you need PR to master? |
Thanks for the contribution, @DanieliMi. We need documentation PRs to point to master, so they can get picked up by our automation systems. Can you please update and rebase this PR to |
@dobooth Shall I force push the rebase or create a new branch from master, cherry pick the commits and open a new PR? The problem is my patch branch is from develop. |
@DanieliMi It probably better to make a new branch from master and cherry pick. |
Description
As mentioned in #339 the MFTF doesn't support executing CLI command if the web server points to
<MAGE_ROOT_DIR>/pub
as recommended in the DevDocs. I added information about it in the docs. It is not mentioned currently and might save other developers some time figuring it out (it would've saved me some time).Contribution checklist