Skip to content

[RISCV] Use iXLen for ptr<->int casts in vararg.ll #74426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 5, 2023
Merged

[RISCV] Use iXLen for ptr<->int casts in vararg.ll #74426

merged 1 commit into from
Dec 5, 2023

Conversation

topperc
Copy link
Collaborator

@topperc topperc commented Dec 5, 2023

Also use ABI alignment for ptr sized objects.

This makes the code more sane and avoids only loading part of what was stored by vastart on RV64.

@topperc
[RISCV] Use iXLen for ptr<->int casts in vararg.ll
dbc3c9a 
Also use ABI alignment for ptr sized objects.

This makes the code more sane and avoids only loading part of what
was stored by vastart on RV64.
@topperc topperc requested review from asb and wangpc-pp December 5, 2023 07:32
wangpc-pp
wangpc-pp approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@wangpc-pp wangpc-pp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@topperc topperc merged commit 9e4210f into llvm:main Dec 5, 2023
@topperc topperc deleted the pr/vararg-test branch December 5, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangpc-pp wangpc-pp wangpc-pp approved these changes

@asb asb Awaiting requested review from asb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@topperc @wangpc-pp