Skip to content

Fix test pfalse-v4i1.ll added in #138712 to require asserts. #139822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 16, 2025

Conversation

dyung
Copy link
Collaborator

@dyung dyung commented May 14, 2025

The main branch commit 57e8899 was was cherry-picked to the release/20.x branch in ae97a56 and it did not include a follow-up fix that I made to the test which was failing when run in a configuration that did not include asserts. This cherry-pick should fix that as it did on main.

This test failure was seen on one of our internal bots that builds without asserts enabled.

@llvmbot
Copy link
Member

llvmbot commented May 14, 2025

@llvm/pr-subscribers-backend-hexagon

Author: None (dyung)

Changes

The main branch commit 57e8899 was was cherry-picked to the release/20.x branch in ae97a56 and it did not include a follow-up fix that I made to the test which was failing when run in a configuration that did not include asserts. This cherry-pick should fix that as it did on main.

This test failure was seen on one of our internal bots that builds without asserts enabled.


Full diff: https://github.com/llvm/llvm-project/pull/139822.diff

1 Files Affected:

  • (modified) llvm/test/CodeGen/Hexagon/isel/pfalse-v4i1.ll (+1)
diff --git a/llvm/test/CodeGen/Hexagon/isel/pfalse-v4i1.ll b/llvm/test/CodeGen/Hexagon/isel/pfalse-v4i1.ll
index c0904b8b4fdd6..2c26bb1e310ea 100644
--- a/llvm/test/CodeGen/Hexagon/isel/pfalse-v4i1.ll
+++ b/llvm/test/CodeGen/Hexagon/isel/pfalse-v4i1.ll
@@ -1,4 +1,5 @@
 ; RUN: llc -march=hexagon -debug-only=isel 2>&1 < %s - | FileCheck %s
+; REQUIRES: asserts
 
 ; CHECK: [[R0:%[0-9]+]]:intregs = A2_tfrsi 0
 ; CHECK-NEXT: predregs = C2_tfrrp killed [[R0]]:intregs

@tstellar tstellar force-pushed the backport-test-fix branch from 340d199 to ff2e8f9 Compare May 16, 2025 23:36
@tstellar tstellar merged commit ff2e8f9 into llvm:release/20.x May 16, 2025
7 of 10 checks passed
@github-project-automation github-project-automation bot moved this from Needs Merge to Done in LLVM Release Status May 16, 2025
Copy link

@dyung (or anyone else). If you would like to add a note about this fix in the release notes (completely optional). Please reply to this comment with a one or two sentence description of the fix. When you are done, please add the release:note label to this PR.

@dyung dyung deleted the backport-test-fix branch May 16, 2025 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

4 participants