llvm-reduce: Defer a shouldKeep call in operand reduction #133387
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
arsenm
requested review from
aeubanks,
jayfoad,
jcranmer-intel,
nhaehnle and
regehr
aeubanks
approved these changes
Mar 28, 2025
arsenm
force-pushed
the
users/arsenm/llvm-reduce/do-not-reduce-alloca-size-to-0
branch
from
33ce163 to
8b7fcfc
Compare
arsenm
force-pushed
the
users/arsenm/llvm-reduce/defer-shouldKeep-check-reduce-operands
branch
from
58d33e1 to
fa597dd
Compare
arsenm
force-pushed
the
users/arsenm/llvm-reduce/do-not-reduce-alloca-size-to-0
branch
2 times, most recently
from
8cad6a9 to
c2e2461
Compare
Base automatically changed from
users/arsenm/llvm-reduce/do-not-reduce-alloca-size-to-0
to
main
April 2, 2025 06:44
Ideally shouldKeep is only called in contexts that will successfully do something.
arsenm
force-pushed
the
users/arsenm/llvm-reduce/defer-shouldKeep-check-reduce-operands
branch
from
fa597dd to
662bae4
Compare
arsenm
deleted the
users/arsenm/llvm-reduce/defer-shouldKeep-check-reduce-operands
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ideally shouldKeep is only called in contexts that will successfully
do something.