llvm-reduce: Add reduceOperandsToPoison reduction #132862
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 25, 2025
This stack of pull requests is managed by Graphite. Learn more about stacking. |
arsenm
requested review from
aeubanks,
jayfoad,
jcranmer-intel,
nhaehnle and
regehr
arsenm
force-pushed
the
users/arsenm/llvm-reduce/fix-assert-operands-to-zero-target-ext-type
branch
from
2eab5bb to
633b42c
Compare
Base automatically changed from
users/arsenm/llvm-reduce/fix-assert-operands-to-zero-target-ext-type
to
main
March 25, 2025 04:38
arsenm
force-pushed
the
users/arsenm/llvm-reduce/add-reduce-operands-poison
branch
from
7271ac9 to
e40a40c
Compare
|
I'm not personally a fan of reducing to poison. this can make test cases smaller but the cognitive load of understanding poison is significant, so I'm not sure this is really a win |
The alternative for target extension types that don't support zero initializer is to do nothing, which is not a win |
arsenm
force-pushed
the
users/arsenm/llvm-reduce/add-reduce-operands-poison
branch
from
e40a40c to
705dd28
Compare
arsenm
force-pushed
the
users/arsenm/llvm-reduce/add-reduce-operands-poison
branch
from
705dd28 to
7e067d4
Compare
aeubanks
approved these changes
Apr 1, 2025
| @@ -168,3 +166,18 @@ void llvm::reduceOperandsNaNDeltaPass(Oracle &O, ReducerWorkItem &WorkItem) { | |||
| }; | |||
| extractOperandsFromModule(O, WorkItem, ReduceValue); | |||
| } | |||
|
|
|||
| void llvm::reduceOperandsPoisonDeltaPass(Oracle &O, ReducerWorkItem &WorkItem) { | |||
There was a problem hiding this comment.
can you add a comment that we're only doing this for non-constant TargetExtTypes?
For now use it only for TargetExtTypes, which do not always support zero initializers.
arsenm
force-pushed
the
users/arsenm/llvm-reduce/add-reduce-operands-poison
branch
from
7e067d4 to
0d4807e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now use it only for TargetExtTypes, which do not always support
zero initializers.