[CIR] Add EhSetjmpOp to CIR dialect
#1895
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Can you rebase this PR so the checks can run? The changes lgtm though. |
Contributor
Author
|
oh wow i didnt realized it has conflict |
Collaborator
Looks like it doesn't include the changes from this revert commit: 7f95114 |
badumbatish
force-pushed
the
setjmp_op
branch
from
bd44bff to
33f1001
Compare
badumbatish
requested review from
andykaylor,
bcardosolopes,
lanza and
xlauko
as code owners
Contributor
Author
should be fixed now |
Collaborator
Thanks, will merge once green |
tommymcm
reviewed
Sep 8, 2025
Collaborator
tommymcm
left a comment
tommymcm
left a comment
There was a problem hiding this comment.
Just noticed that the op class doesn't following class naming convention.
tommymcm
changed the title
EhSetjmpOp to CIR dialect
Contributor
Author
|
welp that was awkward, thanks for the catch Tommy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1849.
#1889 was merged without updating existing test cases that still use the original ptr stride op formatting.
This PR fixes those test cases