Skip to content

[CIR][NFC] Update formatting for ptr stride op #1889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 5, 2025
Merged

[CIR][NFC] Update formatting for ptr stride op #1889

merged 1 commit into from
Sep 5, 2025

Conversation

@badumbatish
Copy link
Contributor

@badumbatish badumbatish commented Sep 4, 2025

Fixes #1888.

#1863 requires this to move forward

tommymcm
tommymcm approved these changes Sep 4, 2025
View reviewed changes
Copy link
Collaborator

@tommymcm tommymcm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bcardosolopes bcardosolopes changed the title [CIR] [NFC] Update formatting for ptr stride op [CIR][NFC] Update formatting for ptr stride op Sep 5, 2025
@bcardosolopes bcardosolopes merged commit 29b2a4e into llvm:main Sep 5, 2025
9 of 10 checks passed
tommymcm pushed a commit to tommymcm/clangir that referenced this pull request Sep 5, 2025
@badumbatish
[CIR][NFC] Update formatting for ptr stride op (llvm#1889)
7837d47 
Fixes llvm#1888.

llvm#1863 requires this to move forward
@badumbatish badumbatish mentioned this pull request Sep 6, 2025
Merged
bcardosolopes pushed a commit that referenced this pull request Sep 8, 2025
@badumbatish
[CIR] Add EhSetjmpOp to CIR dialect (#1895)
4914dc7 
Fixes #1849.

#1889 was merged without updating existing test cases that still use the
original ptr stride op formatting.

This PR fixes those test cases
@badumbatish badumbatish deleted the better_printing branch September 29, 2025 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tommymcm tommymcm tommymcm approved these changes

@lanza lanza Awaiting requested review from lanza lanza is a code owner

@bcardosolopes bcardosolopes Awaiting requested review from bcardosolopes bcardosolopes is a code owner

@xlauko xlauko Awaiting requested review from xlauko xlauko is a code owner

@andykaylor andykaylor Awaiting requested review from andykaylor andykaylor is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[CIR] Update formatting for ptr stride op

3 participants

@badumbatish @tommymcm @bcardosolopes