feat: implement keyword and hybrid search for Weaviate provider #3264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristianZaccaria
requested review from
ashwinb,
bbrowning,
ehhuang,
hardikjshah,
leseb,
mattf,
raghotham,
reluctantfuturist,
slekkala1,
terrytangyuan and
yanxi0830
as code owners
meta-cla
bot
added
the
CLA Signed
ChristianZaccaria
force-pushed
the
hybrid-search-weaviate
branch
from
7de1961 to
9feecce
Compare
2000krysztof
previously requested changes
Aug 28, 2025
ChristianZaccaria
force-pushed
the
hybrid-search-weaviate
branch
from
9feecce to
8f3bb59
Compare
franciscojavierarceo
requested changes
Sep 1, 2025
There was a problem hiding this comment.
Some small nits but this looks mostly good. Thank you @ChristianZaccaria!
|
My suggestions were addressed so lgtm. Very nice work. |
ChristianZaccaria
force-pushed
the
hybrid-search-weaviate
branch
2 times, most recently
from
8493fad to
8daf980
Compare
|
lgtm |
ChristianZaccaria
force-pushed
the
hybrid-search-weaviate
branch
2 times, most recently
from
8205a94 to
8949964
Compare
leseb
requested changes
Sep 5, 2025
ChristianZaccaria
force-pushed
the
hybrid-search-weaviate
branch
from
8949964 to
1053c1e
Compare
leseb
requested changes
Sep 8, 2025
ChristianZaccaria
force-pushed
the
hybrid-search-weaviate
branch
from
1053c1e to
d873408
Compare
ChristianZaccaria
force-pushed
the
hybrid-search-weaviate
branch
from
d873408 to
c06c467
Compare
|
Weird, some unrelated tests failed, seem like a flake. Will push again to test. Edit: The tests passed now. |
ChristianZaccaria
force-pushed
the
hybrid-search-weaviate
branch
2 times, most recently
from
897774d to
0e97b5e
Compare
leseb
reviewed
Sep 12, 2025
ChristianZaccaria
force-pushed
the
hybrid-search-weaviate
branch
2 times, most recently
from
183719d to
400b0aa
Compare
ChristianZaccaria
force-pushed
the
hybrid-search-weaviate
branch
from
400b0aa to
82b41e3
Compare
ChristianZaccaria
force-pushed
the
hybrid-search-weaviate
branch
from
82b41e3 to
fdedf17
Compare
ChristianZaccaria
force-pushed
the
hybrid-search-weaviate
branch
from
fdedf17 to
920c2a3
Compare
|
Rebased, I think we are ready to merge. |
franciscojavierarceo
approved these changes
Sep 22, 2025
franciscojavierarceo
dismissed
2000krysztof’s stale review
Feedback addressed.
leseb
approved these changes
Oct 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Closes #3010
Test Plan
Unit tests and integration tests should pass on this PR.