chore: tidyup V2 #290
Merged
chore: tidyup V2 #290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
thomasyuill-livekit
requested review from
1egoman,
bcherry,
lukasIO and
rektdeckard
thomasyuill-livekit
changed the title
rektdeckard
approved these changes
Oct 16, 2025
Comment on lines
+38
to
40
| // for LiveKit Cloud Sandbox | ||
| sandboxId: undefined, | ||
| agentName: undefined, |
Contributor
There was a problem hiding this comment.
👍 I look forward to this sandbox config logic getting much simpler in the future!
thomasyuill-livekit
force-pushed
the
thomasyuill/dgn-191-react-starter-clean-up-ui-code-v2
branch
from
e05d610 to
b7d411b
Compare
thomasyuill-livekit
force-pushed
the
thomasyuill/dgn-191-react-starter-clean-up-ui-code-v2
branch
from
f7be5f4 to
edb66b7
Compare
thomasyuill-livekit
force-pushed
the
thomasyuill/dgn-191-react-starter-clean-up-ui-code-v2
branch
from
edb66b7 to
269835d
Compare
thomasyuill-livekit
force-pushed
the
thomasyuill/dgn-191-react-starter-clean-up-ui-code-v2
branch
from
269835d to
397793a
Compare
thomasyuill-livekit
force-pushed
the
thomasyuill/dgn-191-react-starter-clean-up-ui-code-v2
branch
from
397793a to
ebb52d3
Compare
thomasyuill-livekit
force-pushed
the
thomasyuill/dgn-191-react-starter-clean-up-ui-code-v2
branch
from
ebb52d3 to
5a69663
Compare
thomasyuill-livekit
force-pushed
the
thomasyuill/dgn-191-react-starter-clean-up-ui-code-v2
branch
from
5a69663 to
bea811b
Compare
thomasyuill-livekit
deleted the
thomasyuill/dgn-191-react-starter-clean-up-ui-code-v2
branch
abdul-0-muheed
pushed a commit
to abdul-0-muheed/sdc-joint-frontend
that referenced
this pull request
Oct 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restores: #286
Resolves: https://linear.app/livekit/issue/DGN-191/react-starter-clean-up-ui-code
Resolves: https://linear.app/livekit/issue/CLT-2149/integrate-tokensource-into-agent-starter-react
Fixes explicit dispatch using
agentNameconfig #288During the clean up, in an effort to simplify the template, I erased the undefined properties
sandboxIdandagentNamefromapp-config.tsbecause it was not clear that these are properties specific to LiveKit Cloud Sandbox and I felt they added noise to the code base.What I didn't realize was that in the Sandbox environment
getAppConfigfilters the config object fetched from LiveKit Cloud based on the keys present inapp-config.ts. When I deletedagentName: undefinedit no longer accepted it as a valid config key.sandboxIdis an exception. It's never filtered. It is set directly, before the filter check, so when I tested removing thesandbox: undefinedit had no effect in the staging environment. I incorrectly assumed that removingagentName: undefinedwas fine too.