Skip to content

TypeScript compiler error that breaks transitions in tutorials. #1128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AndrewJakubowicz opened this issue May 19, 2023 · 3 comments · Fixed by #1131
Closed

TypeScript compiler error that breaks transitions in tutorials. #1128

AndrewJakubowicz opened this issue May 19, 2023 · 3 comments · Fixed by #1131
Assignees

Comments

@AndrewJakubowicz
Copy link
Contributor

AndrewJakubowicz commented May 19, 2023

Found while manually testing out the whole site #1127. Then confirmed the issue is in production.

Impact of issue is that while navigating the Learn tutorials a certain section may break and stop working until the user refreshes the page.
I have not root caused the issue, and why it appears on only certain tutorials and certain direction navigations.

Repros

  • Build a tooltip element: Progressing from Step 8 -> Step 9.
  • Build a word viewer!: Progressing from Step 2 -> Step 1.

Every other tutorial does not have this issue. (Manually checked both forward and backwards navigation).

Investigation

The error message matches microsoft/TypeScript#49738. A possible solution may be updating TypeScript.

I am not able to reproduce this issue on local dev, only preview environments and production.
A repro is possible on Firefox.

@AndrewJakubowicz AndrewJakubowicz self-assigned this May 19, 2023
@AndrewJakubowicz AndrewJakubowicz changed the title TypeScript compiler error that breaks two page transitions in tutorials. TypeScript compiler error that breaks transitions in tutorials. May 19, 2023
@AndrewJakubowicz
Copy link
Contributor Author

Issue seems to be the addition of a new import to lit/directives in both cases.

@AndrewJakubowicz
Copy link
Contributor Author

Maybe related to microsoft/TypeScript#52636?

@AndrewJakubowicz
Copy link
Contributor Author

I've manually verified that both google/playground-elements#369 and upgrading playground-elements to TS version 5.0.4 fixes the issue.

Is there a preference for which should be tackled?

We'll probably want to update the bundled TypeScript within playground-elements to TS 5 eventually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
1 participant