Fork samples so versioned Lit 3 docs playground samples now use Lit 3 pre-release #1127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documentation in the v3 subdirectory now uses the Lit 3 pre-release. How Renamed samples/docs to samples/v2-docs & duplicated it into v3-docs. Then forked `base.json` into `v2-base.json` and `v3-base.json`. Then replaced all `playground-example` and `playground-ide` usages with the versioned counterpart. Result All unversioned content still uses Lit 2, but the versioned v3 docs now show samples on the Lit 3 pre-release.
|
A live preview of this PR will be available at the URL(s) below. https://pr1127-f4c12a6---lit-dev-5ftespv5na-uc.a.run.app/ |
AndrewJakubowicz
changed the title
AndrewJakubowicz
changed the title
AndrewJakubowicz
changed the title
augustjk
reviewed
May 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1124
Result of this change is that the docs/v3 subdirectory now uses Lit 3 pre-release for live code samples. All unversioned (and explicitly v2) tutorials, playgrounds, samples now explicitly depend on
v2-base.json, with behavior unchanged.How
Renamed samples/docs to samples/v2-docs & duplicated it into v3-docs. Then forked
base.jsonintov2-base.jsonandv3-base.json.Then replaced all
playground-exampleandplayground-ideusages with the versioned counterpart depending on whether the docs are indocs/v2ordocs/v3directories.Testing
Some of our integration tests check this. However I also manually went page by page and inspected our playgrounds.
Additional security is that if a file path was broken in the
playground-exampleorplayground-ideshortcode, we get a build error.While testing this PR I found #1128 - however it is non blocking because it's also present in prod.