Skip to content

Update playground-elements to v0.18.0 #1131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 25, 2023

Conversation

AndrewJakubowicz
Copy link
Contributor

@AndrewJakubowicz AndrewJakubowicz commented May 25, 2023

Fixes #1128

Testing

Apart from our unit test coverage, I also manually checked the tutorials & code samples on the site.

Because the bundled version has been updated to TS 5, there is a chance that certain gists and prior code now has TS errors. However that does not seem to be avoidable unless we add a feature to bundle TypeScript versions.

@github-actions
Copy link

A live preview of this PR will be available at the URL(s) below.
The latest URL will be appended to this comment on each push.
Each build takes ~5-10 minutes, and will 404 until finished.

https://pr1131-835177a---lit-dev-5ftespv5na-uc.a.run.app/

@AndrewJakubowicz AndrewJakubowicz requested a review from augustjk May 25, 2023 19:41
Copy link
Member

@augustjk augustjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! I can confirm the issue is gone for me in the preview.

@AndrewJakubowicz AndrewJakubowicz merged commit 07aa54c into main May 25, 2023
@AndrewJakubowicz AndrewJakubowicz deleted the update-playground-elements-v0.18.0 branch May 25, 2023 20:31
@AndrewJakubowicz AndrewJakubowicz self-assigned this Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

TypeScript compiler error that breaks transitions in tutorials.
2 participants