Modernize kb layouts #12758

mtwebster · 2025-02-25T15:20:45Z

All related PRs:
https://github.com/pulls?q=is%3Aopen+is%3Apr+org%3Alinuxmint+head%3Amodernize-kb-layouts

Includes:

notes:

* cinnamon-screensaver continues to use caribou for its osk implementation
/usr/libexec/ibus-setup-sunpinyin from package ibus-sunpinyin is broken in python 3.10 and newer. ref: sunpinyin/sunpinyin@f299e0b

ref: linuxmint/wayland#14

silverhadch · 2025-03-12T19:07:17Z

How do we compile it and install it tho?

pewgar · 2025-03-15T11:59:36Z

the layouts tab still doesn't show up in the keyboard settings, terminal?

mtwebster · 2025-03-15T12:37:19Z

the layouts tab still doesn't show up in the keyboard settings, terminal?

It should..

Are there any errors when running cinnamon-settings keyboard from a terminal? Did you build and install the cinnamon-desktop branch also?

mtwebster · 2025-03-15T12:39:28Z

How do we compile it and install it tho?

In Mint you should be able to clone this repo, and build using dpkg-buildpackage, otherwise you use meson directly to build it. Honestly, if you're not already comfortable doing this sort of thing I would avoid this and wait, as there's a good chance you could make your system (temporarily, at least) unusable.

silverhadch · 2025-03-16T15:14:59Z

@mtwebster
it produced an non functional Cinnamon both Sessions but thank God i used BTRFS and was back up running in a minute. (should really be the default or better selectable instead of manuall partitioning)

The Xorg session was missing the panel and the Wayland session crashed after 10 seconds and only showed the cursor.

pewgar · 2025-03-16T20:07:47Z

the layouts tab still doesn't show up in the keyboard settings, terminal?

It should..

Are there any errors when running cinnamon-settings keyboard from a terminal? Did you build and install the cinnamon-desktop branch also?

oh, dw im just a normie and for whatever reason said something stupid without having this installed. i'll wait for this to be added into the system

MagicBOTAlex · 2025-04-07T04:52:34Z

Just donated 5 EUR (The website says 5$ though). Not much, since I normally don't contribute.

But hopefully Wayland on Mint soon! (I NEED FRACTIONAL SCALING)

ref: linuxmint/cinnamon#12758

Copilot

Copilot reviewed 96 out of 100 changed files in this pull request and generated 2 comments.

Files not reviewed (4)

data/README.osk-layouts: Language not supported
data/cinnamon-osk-layouts.gresource.xml: Language not supported
data/cldr2json/test/data/fr-t-k0-android.xml: Language not supported
data/meson.build: Language not supported

Comments suppressed due to low confidence (1)

data/cldr2json/cldr2json.py:126

Consider correcting the spelling in the error message: 'explicitely' should be 'explicitly'.

raise KeyError("layout %s explicitely disabled in overrides" % locale)

Copilot · 2025-04-15T19:30:51Z

data/cldr2json/test/test_cldr2json.py

+class LoadXKBMapplings(unittest.TestCase):
+    def test_dictionnary(self):


The class name 'LoadXKBMapplings' appears to be misspelled. Consider renaming it to 'LoadXKBMappings'.

Suggested change

class LoadXKBMapplings(unittest.TestCase):

def test_dictionnary(self):

class LoadXKBMappings(unittest.TestCase):

Copilot · 2025-04-15T19:30:52Z

data/cldr2json/test/test_cldr2json.py

+
+
+class LoadXKBMapplings(unittest.TestCase):
+    def test_dictionnary(self):


The method name 'test_dictionnary' contains a misspelling; 'dictionary' is likely the intended word.

Suggested change

def test_dictionnary(self):

def test_dictionary(self):

ref: linuxmint/cinnamon#12758

- Fix viewing layout from the applet menu - Fix sorting, heading for the add layout dialog - Fix syncing of keybindings between keyboard settings and xlet and various individual setting pages.

…ft-clicking on some items

Multiple layouts can be defined here.

the Lightbox is used properly.

default layouts. This reads from /etc/default/keyboard so is useful for Mint as well as other distros, and keeps us from having to parse a text file ourselves.

clutter modals.

away from being an IconApplet.

KeyboardManager when the layout list changes, not when a layout gets activated.

ref: linuxmint/cinnamon#12758

* Handle layout switching thru cinnamon, remove use of XApp. ref: linuxmint/cinnamon#12758 * passwordEntry: Always set a layout source.

Fantu · 2025-09-23T12:54:43Z

On d/control I saw only remove of caribou gir and seems strange that is only deps changes with this very big PR.
From a very fast look I saw on 2 new files:
const { Clutter, GLib, GObject, Graphene, Meta, St } = imports.gi;
So seems at least add of gir1.2-graphene-1.0 is missed, but is possible other gir and/or python packages are missed which are things that are not detectable by build errors in a clean and minimal environment.
Unfortunately, however, I don't have time to do a thorough check on all the changes in this PR.

mtwebster · 2025-09-23T13:31:51Z

gir1.2-graphene is a dependency in muffin's gir package, we've been using it in Cinnamon since 5.4:

Package: gir1.2-meta-muffin-0.0
Source: muffin
Version: 6.4.1
Architecture: amd64
Maintainer: Linux Mint <[email protected]>
Installed-Size: 532
Depends: libmuffin0 (= 6.4.1), gir1.2-atk-1.0, gir1.2-cairo-1.0, gir1.2-cdesktopenums-3.0, gir1.2-gdk-3.0 (>= 3.19.8), gir1.2-gl-1.0, gir1.2-gobject-2.0, gir1.2-graphene-1.0 (>= 1.9.3), gir1.2-gtk-3.0 (>= 3.19.8), gir1.2-json-1.0 (>= 0.13.2-1~), gir1.2-pango-1.0 (>= 1.2.0), gir1.2-pangocairo-1.0 (>= 1.2.0), gir1.2-xfixes-4.0, gir1.2-xlib-2.0

Another major removal was part of libxapp (KbdLayoutController that used libgnomekbd) - we still use XApp for other things so that dependency is unchanged.

Fantu · 2025-09-23T14:09:36Z

Is important that all software have its build-deps and deps complete, I think it's one of the basic things to do, but if someone thinks it's unnecessary, just consider that there could be problems if you don't have the complete dependencies but "everything works" because there are required dependencies in other dependent or installed software. For example, if the dependency that has it stops using it and removes it, or if the software it has isn't co-installed in all cases.
Are things already happened.

This is brought in by gir1.2-meta-muffin but better to be explicit here.

mtwebster · 2025-09-23T14:44:37Z

Fixed - c15d543

- Support both xkcb layouts and input methods (IBus only so far) - Support both Xorg and Wayland - Replace libcaribou dependency with a native OSK with IM completion for some IBUS engines and layout support - Remove dependencies on libgnomekbd, libcaribou, xapp - Switch to native settings (vs region panel in CCC) See #12758

clefebvre · 2025-09-23T18:15:02Z

Merged manually in master.

pewgar · 2025-10-19T17:06:48Z

Merged manually in master.

phew

mtwebster mentioned this pull request Feb 25, 2025

Schema changes for keyboard layout modernization linuxmint/cinnamon-desktop#252

Closed

mtwebster marked this pull request as draft February 25, 2025 17:55

mtwebster force-pushed the modernize-kb-layouts branch from 1b89e05 to c486045 Compare March 8, 2025 15:00

mtwebster mentioned this pull request Mar 12, 2025

Cannot change keyboard layout while on wayland session. linuxmint/wayland#14

Closed

ImAwsumm approved these changes Mar 17, 2025

View reviewed changes

mtwebster force-pushed the modernize-kb-layouts branch 2 times, most recently from 6ed656c to 6998441 Compare March 31, 2025 13:07

mtwebster mentioned this pull request Apr 9, 2025

Modernize kb layouts linuxmint/cinnamon-settings-daemon#410

Merged

mtwebster added a commit to linuxmint/cinnamon-control-center that referenced this pull request Apr 9, 2025

Remove region panel, misc related code.

4cc5f3f

ref: linuxmint/cinnamon#12758

This was referenced Apr 9, 2025

Remove region panel, misc related code. linuxmint/cinnamon-control-center#355

Merged

Revert "x11 backend: Don't let muffin reset the keyboard layout..." linuxmint/muffin#719

Merged

mtwebster added a commit to linuxmint/cinnamon-screensaver that referenced this pull request Apr 15, 2025

Handle layout switching thru cinnamon, remove use of XApp.

49467fa

ref: linuxmint/cinnamon#12758

mtwebster mentioned this pull request Apr 15, 2025

Handle layout switching thru cinnamon, remove use of XApp. linuxmint/cinnamon-screensaver#477

Merged

mtwebster added a commit to linuxmint/cinnamon-screensaver that referenced this pull request Apr 15, 2025

Handle layout switching thru cinnamon, remove use of XApp.

93b7b95

ref: linuxmint/cinnamon#12758

mtwebster requested a review from Copilot April 15, 2025 19:30

Copilot AI reviewed Apr 15, 2025

View reviewed changes

This was referenced Apr 16, 2025

Add ibus-pinyin to Simplified Chinese packages. linuxmint/mintlocale#86

Open

Remove xapp, use LightDMLayout for keyboard layout changes. linuxmint/slick-greeter#259

Closed

Modernize kb layouts linuxmint/xapp#190

Merged

This comment was marked as spam.

Sign in to view

ImAwsumm approved these changes Apr 25, 2025

View reviewed changes

mtwebster force-pushed the modernize-kb-layouts branch from 3510e2e to 83a5902 Compare May 5, 2025 17:32

mtwebster added a commit to linuxmint/cinnamon-screensaver that referenced this pull request May 21, 2025

Handle layout switching thru cinnamon, remove use of XApp.

adb4a1e

ref: linuxmint/cinnamon#12758

mtwebster and others added 14 commits September 22, 2025 09:36

Various:

7ec5d7d

- Fix viewing layout from the applet menu - Fix sorting, heading for the add layout dialog - Fix syncing of keybindings between keyboard settings and xlet and various individual setting pages.

Fix layout activation.

1754bc2

Explicitly apply the primary layout at startup.

802d0b8

_menus.scss: fix spontaneous increase size of the pop-up menu when le…

c705e1c

…ft-clicking on some items

_calendar.scss: enable backlight for calendar-today-home-button

4239b5c

Make the /etc/default/keyboard parser more capable.

6372d43

Multiple layouts can be defined here.

Fix keyboard positioning

237666c

Add 'important' marker to ibus candidate popups

147ae75

Improve osk activation and layout.

1144873

Destroy runDialog when keyboard is enabled/disabled, to make sure

7bf2618

the Lightbox is used properly.

keyboardManager.js: Use system fdo locale1 interface for loading

9f00a07

default layouts. This reads from /etc/default/keyboard so is useful for Mint as well as other distros, and keeps us from having to parse a text file ourselves.

virtualKeyboard.js: Don't show the keyboard automatically with

1bfc0d4

clutter modals.

keyboard applet: Fix visibility during panel-edit after moving

cbd5bd1

away from being an IconApplet.

keyboardManager.js: Remove 'interactive' concept and update the

e51fb79

KeyboardManager when the layout list changes, not when a layout gets activated.

mtwebster force-pushed the modernize-kb-layouts branch from e8e4988 to e51fb79 Compare September 22, 2025 16:27

clefebvre pushed a commit to linuxmint/cinnamon-control-center that referenced this pull request Sep 23, 2025

Remove region panel, misc related code. (#355)

9881cf7

ref: linuxmint/cinnamon#12758

mtwebster added 3 commits September 23, 2025 10:40

Add gir.1.2-graphene-1.0 to depends.

c15d543

This is brought in by gir1.2-meta-muffin but better to be explicit here.

Fix OSK desktop launcher.

4ba2bdc

extension.js: Allow the keyboard layout applet in Wayland sessions.

a41ec08

Remove animation from virtual keyboard toggling.

cfba8fa

clefebvre closed this Sep 23, 2025

NULL0xFF mentioned this pull request Oct 14, 2025

[BUG] Can't change language in startmenu searchbar #11115

Open

		class LoadXKBMapplings(unittest.TestCase):
		def test_dictionnary(self):

	class LoadXKBMapplings(unittest.TestCase):
	def test_dictionnary(self):
	class LoadXKBMappings(unittest.TestCase):

Modernize kb layouts #12758

Modernize kb layouts #12758

Uh oh!

Conversation

mtwebster commented Feb 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

silverhadch commented Mar 12, 2025

Uh oh!

pewgar commented Mar 15, 2025

Uh oh!

mtwebster commented Mar 15, 2025

Uh oh!

mtwebster commented Mar 15, 2025

Uh oh!

silverhadch commented Mar 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pewgar commented Mar 16, 2025

Uh oh!

MagicBOTAlex commented Apr 7, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 15, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 15, 2025

Choose a reason for hiding this comment

Uh oh!

This comment was marked as spam.

Fantu commented Sep 23, 2025

Uh oh!

mtwebster commented Sep 23, 2025

Uh oh!

Fantu commented Sep 23, 2025

Uh oh!

mtwebster commented Sep 23, 2025

Uh oh!

clefebvre commented Sep 23, 2025

Uh oh!

pewgar commented Oct 19, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

mtwebster commented Feb 25, 2025 •

edited

Loading

silverhadch commented Mar 16, 2025 •

edited

Loading