Skip to content

Conversation

@mtwebster
Copy link
Member

@mtwebster mtwebster commented Apr 17, 2025

@Fantu
Copy link
Contributor

Fantu commented Apr 17, 2025

Hi, this PR remove some functions (looking symbols file), normally in cinnamon software you didn't soname dump even if should be done on api break but as xapp is used also by other softwares out of cinnamon (where for example on Debian I do strict deps, break of reverse deps and upload simultaneous upload of all components involved as a workaround), so I think that is good do soname bump.

@mtwebster mtwebster force-pushed the modernize-kb-layouts branch from 850321d to dc6cc5a Compare May 21, 2025 12:55
@clefebvre clefebvre changed the title Modernize kb layouts [Next] Modernize kb layouts Jul 30, 2025
@clefebvre clefebvre changed the title [Next] Modernize kb layouts Modernize kb layouts Sep 23, 2025
@clefebvre
Copy link
Member

clefebvre commented Sep 23, 2025

Hi, this PR remove some functions (looking symbols file), normally in cinnamon software you didn't soname dump even if should be done on api break but as xapp is used also by other softwares out of cinnamon (where for example on Debian I do strict deps, break of reverse deps and upload simultaneous upload of all components involved as a workaround), so I think that is good do soname bump.

I agree in theory though I think this has only been used by slick-greeter, cinnamon and cinnamon-screensaver. Do you know of any other software using this?

If so it's not a bump we actually need, it's to keep it in.

@clefebvre
Copy link
Member

I'll merge for now. We can revert if this is needed.

@clefebvre clefebvre merged commit 7a243e3 into master Sep 23, 2025
2 checks passed
@Fantu
Copy link
Contributor

Fantu commented Sep 23, 2025

slick-greeter don't seems that use xapp, or there are incomplete deps? https://github.com/linuxmint/slick-greeter/blob/master/debian/control
the most critical and essential thing would be to at least know if the removed APIs are used by other software outside of the cinnamon components.
Regarding the cinnamon components, as I've seen several times in Debian broken APIs without soname dumps, I assume the maintainers of other distros have also seen them and are acting accordingly to limit the problems. Perhaps at least increasing the major version (to 3) of the xapp version, which will include this change, will help ensure more thorough checking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants