[sql-15] sessions: various functional options for NewSession #984
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellemouton
added
the
no-changelog
Error out if an AddAutopilotSession call has privacy map flags specified but does not activate the privacy mapper.
ellemouton
force-pushed
the
sql15Sessions7
branch
from
cd1f6bf to
acedd76
Compare
ellemouton
changed the title
ellemouton
force-pushed
the
sql15Sessions7
branch
from
acedd76 to
cd29406
Compare
ViktorTigerstrom
approved these changes
Feb 27, 2025
For a cleaner interface, adjust the NewSession method of the Session store such that all optional arguments are functional options.
ellemouton
force-pushed
the
sql15Sessions7
branch
from
cd29406 to
b81742f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a cleaner interface, adjust the NewSession method of the Session
store such that all optional arguments are functional options.
We also now will error out in
AddAutopilotSessionif the caller specifies privacy map flags without actuallyactivating the privacy mapper.