[sql-14] sessions: atomic session creation #980
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellemouton
added
no-changelog
ellemouton
force-pushed
the
sql14Sessions6
branch
from
72d32b0 to
5a28d56
Compare
ellemouton
commented
Feb 20, 2025
session_rpcserver.go
Outdated
| req.DevServer, uniquePermissions, caveats, nil, false, nil, | ||
| session.PrivacyFlags{}, | ||
| ) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("error creating new session: %v", err) | ||
| } | ||
|
|
||
| if err := s.cfg.db.CreateSession(sess); err != nil { | ||
| sess, err = s.cfg.db.CreateSession(sess.ID) |
There was a problem hiding this comment.
note: in this follow up, we add a way to do this in one go for normal (non-autopilot) sessions
ellemouton
force-pushed
the
sql14Sessions6
branch
from
5a28d56 to
374c93f
Compare
ellemouton
force-pushed
the
sql14Sessions6
branch
from
374c93f to
3f94793
Compare
ellemouton
force-pushed
the
sql14Sessions6
branch
2 times, most recently
from
bc53495 to
3e58e19
Compare
ellemouton
force-pushed
the
sql14Sessions6
branch
from
3e58e19 to
c60dc68
Compare
ViktorTigerstrom
approved these changes
Feb 26, 2025
bitromortac
approved these changes
Feb 26, 2025
In this commit, we let StateReserved be the new initial state of a session for when NewSession is called. We then do predicate checks for linked sessions along with unique session alias (ID) and priv key derivations all under the same DB transaction in NewSession. ShiftState then moves a session to StateCreated. Only in StateCreated does a session become usable. With this change, we no longer need to ensure atomic session creation by acquiring the `sessRegMu` mutex in the session RPC server.
This was used to check that all linked sessions are no longer active before attempting to register an autopilot session. But this is no longer needed since this is done within NewSession.
ellemouton
force-pushed
the
sql14Sessions6
branch
from
c60dc68 to
32a34d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #979 for more context.
In this PR, we do the refactor to make session creation happen in 1 atomic DB transaction as described in the issue above.
Fixes #979