Use signal for handling ChannelPending in test_background_event_handling #2165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes two potential panics within the test if the `BackgroundProcessor` for `nodes[0]` consumed the `ChannelPending` event prior to us consuming it manually in `end_open_channel`. The first panic would happen within the event handler, since `ChannelPending` was not being handled. The second panic would happen upon expecting the `ChannelPending` event after handling `nodes[1]`'s `funding_signed` if the `BackgroundProcessor` handled the event first. To ensure we still reliably receive a `ChannelPending` event once possible, we let the `BackgroundProcessor` consume the event and notify it.
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #2165 +/- ##
==========================================
- Coverage 91.30% 91.29% -0.01%
==========================================
Files 102 102
Lines 49981 49987 +6
Branches 49981 49987 +6
==========================================
+ Hits 45636 45638 +2
- Misses 4345 4349 +4
... and 5 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes two potential panics within the test if the
BackgroundProcessorfornodes[0]consumed theChannelPendingevent prior to us consuming it manually inend_open_channel. The first panic would happen within the event handler, sinceChannelPendingwas not being handled. The second panic would happen upon expecting theChannelPendingevent after handlingnodes[1]'sfunding_signedif theBackgroundProcessorhandled the event first. To ensure we still reliably receive aChannelPendingevent once possible, we let theBackgroundProcessorconsume the event and notify it.Fixes #2144.