Skip to content

background-processor tests are flaky #2144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
TheBlueMatt opened this issue Apr 3, 2023 · 4 comments · Fixed by #2165
Closed

background-processor tests are flaky #2144

TheBlueMatt opened this issue Apr 3, 2023 · 4 comments · Fixed by #2165
Assignees
@TheBlueMatt
Labels
flaky test

Comments

@TheBlueMatt
Copy link
Collaborator

I think we regressed with #2141 but it seems like a once-in-1000 crash so need to debug further.
@TheBlueMatt TheBlueMatt added this to the 0.0.115 milestone Apr 3, 2023
@TheBlueMatt TheBlueMatt self-assigned this Apr 3, 2023
This was referenced Apr 3, 2023
Merged
Merged
@TheBlueMatt
Copy link
Collaborator Author

Actually no idea if this regressed or not. Not sure how we can hit this but certainly can't be async related.

@TheBlueMatt TheBlueMatt removed this from the 0.0.115 milestone Apr 3, 2023
@TheBlueMatt
Copy link
Collaborator Author

Removing milestone since it isn't clear to me its a regression and I confused it for another issue I had locally, hopefully the debugging in #2145 makes it clearer whats going on here.

@TheBlueMatt
Copy link
Collaborator Author

Hit this again on macos, 2145 didn't turn up any further debug info :( https://github.com/lightningdevkit/rust-lightning/actions/runs/4630693695/jobs/8192606771?pr=2023

@TheBlueMatt
Copy link
Collaborator Author

Failed again on macOS at #2163 I'm starting to think its a mac issue...

@wpaulino wpaulino mentioned this issue Apr 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TheBlueMatt TheBlueMatt

Labels
flaky test
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use signal for handling ChannelPending in test_background_event_handling wpaulino/rust-lightning
1 participant
@TheBlueMatt