Skip to content

Update docs to specify where PeerManager::process_events is called #1082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 21, 2021

Conversation

vss96
Copy link
Contributor

@vss96 vss96 commented Sep 18, 2021

Doc changes for #1075

@codecov
Copy link

codecov bot commented Sep 18, 2021

Codecov Report

Merging #1082 (ac6bd64) into main (801d6e5) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head ac6bd64 differs from pull request most recent head 2f0f0c9. Consider uploading reports for the commit 2f0f0c9 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1082      +/-   ##
==========================================
- Coverage   90.76%   90.74%   -0.02%     
==========================================
  Files          65       65              
  Lines       33894    33894              
==========================================
- Hits        30764    30758       -6     
- Misses       3130     3136       +6     
Impacted Files Coverage Δ
lightning/src/ln/peer_handler.rs 45.94% <ø> (ø)
lightning/src/ln/functional_tests.rs 97.44% <0.00%> (-0.10%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 801d6e5...2f0f0c9. Read the comment docs.

@vss96
Copy link
Contributor Author

vss96 commented Sep 19, 2021

@TheBlueMatt I hope this should be enough to update the docs?

Copy link
Collaborator

@TheBlueMatt TheBlueMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should mention this call in lightning-net-tokio's three public methods that create connections, but this is fine either way.

Copy link
Contributor

@valentinewallace valentinewallace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK mod squashing the fixup

@TheBlueMatt
Copy link
Collaborator

Can you squash the commits into one? Then happy to land this.

@vss96
Copy link
Contributor Author

vss96 commented Sep 20, 2021

I squashed it into a single commit, but for some reason the check_commits stage is failing

@TheBlueMatt
Copy link
Collaborator

According to github, you now have four commits in the PR. See https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#squashing-commits for instructions on how to squash and force-push.

@vss96 vss96 closed this Sep 21, 2021
@vss96 vss96 reopened this Sep 21, 2021
@vss96 vss96 force-pushed the process_events_docs branch from 0f4b741 to 432507b Compare September 21, 2021 05:01
@vss96
Copy link
Contributor Author

vss96 commented Sep 21, 2021

@valentinewallace I'm not sure how your changes got in when I pushed I could only see my changes in the diff.

@vss96 vss96 force-pushed the process_events_docs branch 2 times, most recently from ac6bd64 to 8befd6c Compare September 21, 2021 06:33
@vss96
Copy link
Contributor Author

vss96 commented Sep 21, 2021

@TheBlueMatt I managed to squash the commit by following the instructions that were given, but somehow i ended up with other file changes 😓

@TheBlueMatt
Copy link
Collaborator

Huh! I'm not entirely sure how that happened. In any case, I went ahead and took the previous version of this PR from yesterday, squashed the commit into one, and pushed it (github, by default, allows maintainers to push to your branches that are associated with a PR).

@TheBlueMatt TheBlueMatt merged commit 4419191 into lightningdevkit:main Sep 21, 2021
@vss96
Copy link
Contributor Author

vss96 commented Sep 21, 2021

Thank you for the help! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants