Skip to content

Clarify Where PeerManager::process_events happens in docs #1075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
TheBlueMatt opened this issue Sep 15, 2021 · 2 comments
Closed

Clarify Where PeerManager::process_events happens in docs #1075

TheBlueMatt opened this issue Sep 15, 2021 · 2 comments
Labels
good first issue Good for newcomers

Comments

@TheBlueMatt
Copy link
Collaborator

Val mentioned at #1043 (comment) that the current docs dont really point out explicitly that users shouldnt need to call process_events directly unless they're not using lightning-net-tokio or one of the other clients provided in our language bindings. We should make sure we cover that.
@TheBlueMatt TheBlueMatt added the good first issue Good for newcomers label Sep 15, 2021
@TheBlueMatt TheBlueMatt mentioned this issue Sep 15, 2021
Merged
@vss96
Copy link
Contributor

vss96 commented Sep 17, 2021

@TheBlueMatt Is this already done? If not I can pick it up.

@TheBlueMatt
Copy link
Collaborator Author

No, feel free to work on this.

@vss96 vss96 mentioned this issue Sep 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TheBlueMatt @vss96