Skip to content

Switch stop signal over to tokio::sync::watch::channel #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2023

Conversation

tnull
Copy link
Collaborator

@tnull tnull commented May 21, 2023

Based on #85, Prerequisite for #93.

@tnull tnull added this to the 0.1 milestone May 21, 2023
@tnull tnull requested a review from wpaulino May 21, 2023 07:07
Copy link

@wpaulino wpaulino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Will wait to approve until the dependent goes through.

@tnull tnull force-pushed the 2023-05-switch-stop-signal branch 2 times, most recently from 8891816 to a95aa8a Compare May 23, 2023 16:42
@tnull tnull force-pushed the 2023-05-switch-stop-signal branch from a95aa8a to 3f233dc Compare May 23, 2023 16:43
@tnull
Copy link
Collaborator Author

tnull commented May 23, 2023

Now rebased on main after #85 was merged, squashed the fixup while at it.

@tnull tnull merged commit 8ba0604 into lightningdevkit:main May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants